Bug 263195 - [api][rseterminals] Remove the dependency from terminals-feature to SSH
Summary: [api][rseterminals] Remove the dependency from terminals-feature to SSH
Status: ASSIGNED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: Future   Edit
Assignee: Anna Dushistova CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 259363
  Show dependency tree
 
Reported: 2009-02-01 20:30 EST by Martin Oberhuber CLA
Modified: 2012-05-09 13:54 EDT (History)
0 users

See Also:

Attachments
The patch that enables the core terminal subsystem for SSH as well as for Telnet (831 bytes, patch)
2010-12-01 11:39 EST, Anna Dushistova CLA 		anna.dushistova: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2009-02-01 20:30:28 EST 
The RSE-terminals-feature should work with Telnet Only, even if SSH is not installed. We should investigate packing the ssh.terminals.subsystem into a different place (I'm not yet sure which one, check how it's done for telnet).
Comment 1 Anna Dushistova CLA 2009-05-18 10:04:14 EDT 
Telnet system type uses "generic" terminal subsystem, defined in org.eclipse.rse.subsystems.terminals.core, which is service independent.
It should be possible to use it with ssh service as well I think, in this case we could probably get rid of org.eclipse.rse.subsystems.terminals.ssh at all.
It might be too late for this change though.
Comment 2 Anna Dushistova CLA 2010-12-01 11:39:04 EST 
Created attachment 184274 [details]
The patch that enables the core terminal subsystem for SSH as well as for Telnet

With this patch, the terminals.ssh subsystem can be removed since it's not needed anymore. Martin, do you think we should go this route?
Comment 3 Martin Oberhuber CLA 2010-12-01 12:31:07 EST 
I'd say test it :)

Does it still work as expected for SSH, when ss.terminals.ssh is actually removed? What happens when using dstore transport and requesting a terminal (I'm sure there are issues, but you enable this with your change)?
Comment 4 Anna Dushistova CLA 2010-12-01 12:35:47 EST 
I tested it with SSH, but didn't try it with dstore.
Comment 5 Martin Oberhuber CLA 2011-02-01 03:28:54 EST 
Anna, can you work on getting this in for M6 (API freeze) ?
Comment 6 Anna Dushistova CLA 2011-02-01 03:49:42 EST 
I'll see what I can do.
Comment 7 Martin Oberhuber CLA 2011-05-31 17:42:08 EDT 
Moving deferred 3.3 api items to 3.4