Community
Participate
Working Groups
The change in bug 258631 which made the ITerminalService public API had a big impact on the RSE Terminals integration, because its API in org.eclipse.rse.subsystems.terminals.core org.eclipse.rse.subsystems.terminals.ssh uses parameters and return values from the org.eclipse.rse.services.terminals package which changed. As a result, the change from bug 258631 introduces a breaking change to the (currently incubating) RSE Terminals integration. I'd like to take this opportunity to have the RSE Terminals integration graduate to version 1.0 in the TM 3.1 timeframe. The integration has been picked up by the Java EE Package already, and it was never a good idea to reference the "internal" ITerminalService stuff from the "public incubating" API in rse.subsystems.terminals.core. Moving RSE-Terminals out of incubation means that we should carefully review the current APIs in org.eclipse.rse.subsystems.terminals.core -- maybe we want to take this opportunity to change something or move it out of public API before we cannot change it any more.
Created attachment 120944 [details] Patch reving rseterminal up to 1.0 Attached patch does the first important steps: * Add the "API Analysis" nature to the 3 rseterminal plugins * Add Class Javadocs everywhere (with an "EXPERIMENTAL" marker) * Move version numbers up to 1.0 everywhere (required by API tooling) * Remove "(Incubation)" from all plug-in and feature names * Register the three new API packages in org.eclipse.rse.doc.isv * Update the site.xml file to pick up the new feature version (1.0) The RSE Tests feature was reved up to 3.1 along the way since it now contains tests for the new generic terminal shell, which is new in 3.1. The change is committed and released for RSE 3.1m4: [259363][api][rseterminals] Move RSE-Terminals out of incubation I'm leaving the bug open to perform the following additional tasks: 1.) Review the org.eclipse.rse.subsystems.terminals.core API classes - might want to get rid of some methods or classes, or change signature 2.) Review all Javadocs 3.) Get rid of the EXPERIMENTAL tag on all Javadocs.
Should finish the API Review by M6.
Created attachment 120958 [details] Additional patch for changing the Downloads page
The two attached patches have been committed. More work is scheduled via bug 263189, bug 263195, bug 247700 and bug 257694.
I believe we can mark this bug fixed, since the "(Incubation)" is gone from all features and downloads, and the feature is part of the standard RSE runtime now. Remaining work will be tracked in the separate bugs mentioned.
