Bug 262205 - BIRT 2.5 build does not work with the latest Eclipse 3.5 SDK
Summary: BIRT 2.5 build does not work with the latest Eclipse 3.5 SDK
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: DataTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 blocker (vote)
Target Milestone: 1.7M5   Edit
Assignee: Brian Fitzpatrick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 263160 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-23 12:05 EST by Cheng-Yee Lin CLA
Modified: 2009-02-04 22:13 EST (History)
6 users (show)

See Also:


Attachments
Patch to update versions (26.49 KB, patch)
2009-01-26 18:00 EST, Brian Fitzpatrick CLA
no flags Details | Diff
patch for one I missed (833 bytes, patch)
2009-01-28 13:39 EST, Brian Fitzpatrick CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cheng-Yee Lin CLA 2009-01-23 12:05:49 EST
When I set up a BIRT installation with the following packages, none of the BIRT UIs (Report Design perspective, BIRT-based projects in the New Project wizard, etc.) are visible:

  eclipse-SDK-I20090122-0800-win32.zip  <--
  emf-runtime-I200901201800.zip
  GEF-runtime-I200901191850.zip
  dtp-1.7.0M5-200901220500.zip
  birt-report-framework-2_5_0-N20090123.zip

When I used the Eclipse SDK package from last week (eclipse-SDK-I20090114-1322-win32.zip) instead, the BIRT UIs can be seen correctly.

This seems to indicate that BIRT needs to react to some recent changes in the Eclipse 3.5 SDK.  This issue is blocking our product's adoption of BIRT.
Comment 1 Zhiqiang Qian CLA 2009-01-23 21:24:00 EST
From the test result page for build I20090122-0800-win32, I can see several tests failed for P2 and JFace, is this the reason?

http://download.eclipse.org/eclipse/downloads/drops/I20090122-0800/testResults.php
Comment 2 Zhiqiang Qian CLA 2009-01-23 22:40:04 EST
Please forget the previous comment, seems the problem is related to com.ibm.icu bundle version change.
Comment 3 Zhiqiang Qian CLA 2009-01-23 23:05:39 EST
following plugins in BIRT have direct dependency on com.ibm.icu, need update the maximum version restriction in manifest to accommodate 4.0.0:

org.eclipse.birt.core
org.eclipse.birt.data
org.eclipse.birt.report.data.oda.jdbc
org.eclipse.birt.report.data.oda.jdbc.ui

Some plugins in DTP package that required by BIRT also need be updated.
Comment 4 Lin Zhu CLA 2009-01-23 23:47:41 EST
The BIRT side fix has been done. The remaining part belongs to datatools project, specifically, the reference to icu in following project should be updated:

org.eclipse.datatools.sqltools.tabledataeditor
org.eclipse.datatools.sqltools.sqleditor
org.eclipse.datatools.sqltools.sqlbuilder
org.eclipse.datatools.sqltools.result
org.eclipse.datatools.sqltools.editor.core
org.eclipse.datatools.sqltools.data.ui
org.eclipse.datatools.sqltools.data.core
org.eclipse.datatools.sqltools.common.ui
org.eclipse.datatools.modelbase.sql.query
org.eclipse.datatools.enablement.sybase.ase
org.eclipse.datatools.enablement.sybase.asa
org.eclipse.datatools.enablement.mysql

org.eclipse.datatools.enablement.msft.sqlserver
org.eclipse.datatools.enablement.msft.sqlserver.ui

org.eclipse.datatools.enablement.ibm.db2.luw.ui
org.eclipse.datatools.enablement.ibm.db2.iseries.ui
org.eclipse.datatools.connectivity
org.eclipse.datatools.connectivity.ui
org.eclipse.datatools.connectivity.ui.dse
org.eclipse.datatools.connectivity.sqm.server.ui
org.eclipse.datatools.connectivity.sqm.core
org.eclipse.datatools.connectivity.sqm.core.ui
org.eclipse.datatools.connectivity.oda.design
org.eclipse.datatools.connectivity.apache.derby
Comment 5 Linda Chan CLA 2009-01-24 00:59:01 EST
The version of com.ibm.icu bundle is now 4.0 in the recent version of Platform SDK 3.5 build.
Most of the DTP bundles (see list in comment #4), like most other projects, have a maximum version tolerance excluding 4.0.0, 
e.g.  com.ibm.icu;bundle-version="[3.4.0,4.0.0)"

Brian, preference on what version to use as the new maximum version tolerance? 5.0.0 exclusive?

Comment 6 Brian Fitzpatrick CLA 2009-01-26 10:25:25 EST
5.0.0 exclusive sounds fine. This isn't one of those things that has changed all that often.
Comment 7 Brian Fitzpatrick CLA 2009-01-26 18:00:26 EST
Created attachment 123836 [details]
Patch to update versions

This patch updates the versions appropriately for connectivity, enablement, and sql dev plug-ins.
Comment 8 Brian Fitzpatrick CLA 2009-01-26 18:26:28 EST
Updated the plugins below with v200901270704

sqltools
	o.e.d.sqltools.common.ui
	o.e.d.s.data.core
	o.e.d.s.data.ui
	o.e.d.s.editor.core
	o.e.d.s.result
	o.e.d.s.sqlbuilder
	o.e.d.s.sqleditor
	o.e.d.s.tabledataeditor
	
enablement
	o.e.d.e.ibm.db2.iseries.ui
	o.e.d.e.ibm.db2.luw.ui
	o.e.d.e.jdt.dbunit
	o.e.d.e.msft.sqlserver.ui
	o.e.d.e.msft.sqlserver
	o.e.d.e.mysql
	o.e.d.e.sybase.asa
	o.e.d.e.sybase.ase
	o.e.d.e.sybase.ui
	
connectivity
	o.e.d.c.apache.derby
	o.e.d.c.oda.design
	o.e.d.c.oda
	o.e.d.c.sqm.core.ui
	o.e.d.c.sqm.core
	o.e.d.c.sqm.server.ui
	o.e.d.c.ui.dse
	o.e.d.c.ui
	o.e.d.c
Comment 9 Brian Fitzpatrick CLA 2009-01-28 13:39:14 EST
Created attachment 124061 [details]
patch for one I missed

This is for o.e.d.modelbase.sql.query
Comment 10 Brian Fitzpatrick CLA 2009-01-28 13:40:01 EST
Reopening to deliver fix
Comment 11 Brian Fitzpatrick CLA 2009-01-28 16:58:50 EST
Delivered to o.e.d.modelbase.sql as tag v200901290556
Comment 12 David Williams CLA 2009-01-28 22:00:51 EST
So, which build will this be in? 
Doesn't seem to be in 
dtp-sdk-1.7.0M5-200901290500
if I'm looking at it right. 


Comment 13 Brian Fitzpatrick CLA 2009-01-29 09:02:50 EST
Most of it was in the http://www.eclipse.org/downloads/download.php?file=/datatools/downloads/drops/N_DTP_1.7/dtp-sdk-1.7.0M5-200901271639.zip build, but the extra (missed) plug-in won't show up until later today in the 20090128 build. 
Comment 14 Brian Fitzpatrick CLA 2009-01-29 09:04:32 EST
Keep in mind that we're still working through the EMF issues however, so DTP is still broken on Eclipse 3.5/EMF 2.5. 
Comment 15 Cheng-Yee Lin CLA 2009-01-29 17:41:46 EST
I have verified that, with the following set of zip files (the latest ones as of testing), the original BIRT issue has been fixed:

  eclipse-SDK-I20090122-0800-win32.zip
  emf-runtime-I200901271800.zip
  GEF-runtime-I200901231850.zip
  dtp-1.7.0M5-200901290500.zip
  birt-report-framework-2_5_0-N20090129.zip

Thanks for the help, including the changes reacting to the ICU issue by the pre-requisite components like DTP and EMF.
Comment 16 Xiaoying Gu CLA 2009-02-01 03:21:09 EST
org.eclipse.birt.report.data.oda.xml/META-INF/MANIFEST.MF need to be updated also.

Reopen for it.
Comment 17 Xiaoying Gu CLA 2009-02-01 03:21:39 EST
*** Bug 263160 has been marked as a duplicate of this bug. ***
Comment 18 Lin Zhu CLA 2009-02-01 03:27:26 EST
Fix the problem in obsoleted oda xml driver.
Comment 19 Xiaoying Gu CLA 2009-02-04 21:46:53 EST
One more missed:

org.eclipse.datatools.sqltools.editor.core.

It's still using ="[3.4.0,4.0.0)" in latest 1.7M5 builds, which blocked BIRT build after upgrade build env to platform M5.
Comment 20 Linda Chan CLA 2009-02-04 21:54:12 EST
The latest issue with org.eclipse.datatools.sqltools.editor.core is tracked in bug #263704.
The retagging described in its comment 3 was not done on sqltools.editor.core.
After sqltools.editor.core is re-tagged, we will need a re-spin of DTP M5 build.
Comment 21 Xiaoying Gu CLA 2009-02-04 22:13:17 EST
I have re-tagged org.eclipse.datatools.sqltools.editor.core to continue the BIRT build. But only the change on MANIFETS.MF was included. Other changes are not in the new tag.

We will respin dtp 1.7M5 again after bug #263704 was resolved.

Marked this bug as fixed.