Bug 261854 - adding/removing TreeItems can be very slow
Summary: adding/removing TreeItems can be very slow
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-01-21 11:36 EST by Grant Gayed CLA
Modified: 2009-01-21 16:23 EST (History)
1 user (show)

See Also:

Attachments
patch (7.22 KB, patch)
2009-01-21 11:37 EST, Grant Gayed CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2009-01-21 11:36:43 EST 
- open the Cocoa class in eclipse
- in the outline view press the Show/Hide Fields tool button
   -> this takes ~1 minute to complete on my machine
   -> eclipse is using setRedraw() here but the Tree implementation is not taking advantage of it
Comment 1 Grant Gayed CLA 2009-01-21 11:37:53 EST 
Created attachment 123250 [details]
patch

(in comment 0 I meant to say the "OS" class)
Comment 2 Grant Gayed CLA 2009-01-21 12:50:03 EST 
Note that TreeItem.setExpanded(boolean) needs a parent.checkItems() as well.
Comment 3 Grant Gayed CLA 2009-01-21 16:23:16 EST 
fixed > 0121