Bug 261741 - [SSH2] Confusing "password" label in passphrase dialog
Summary: [SSH2] Confusing "password" label in passphrase dialog
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks: 261740
  Show dependency tree
 
Reported: 2009-01-20 19:35 EST by Hemang Lavana CLA
Modified: 2019-09-24 13:50 EDT (History)
4 users (show)

See Also:


Attachments
CVS passphrase dialog (7.00 KB, image/gif)
2009-01-21 06:55 EST, Martin Oberhuber CLA
no flags Details
CVS password dialog (7.87 KB, image/gif)
2009-01-21 06:59 EST, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hemang Lavana CLA 2009-01-20 19:35:33 EST
When team/cvs/ssh prompts for passphrase info, I see the following dialog box:

Passphrase for C:\Document and Settings\hlavana\ssh\id_rsa
    User name:  [           ]
    Password:   [           ]
    ^^^^^^^^^

I would like to see "Password" string in the last line replaced with
"Passphrase" to make it explicitly clear. I have often ended up providing my
password here because it is very easy miss reading of the first line where it
mentions that it is expecting a passphrase.

PS: This issue is also seen in RSE (bug 261740).
Comment 1 Martin Oberhuber CLA 2009-01-21 05:36:17 EST
Changed the summary to reflect the actual problem rather than the solution.
Previous value was:
change password label to passphrase in its dialog box

I think that the fix must go into
   org.eclipse.jsch.internal.core.UserInfoImpl#promptPassphrase(String)
since it cannot call 
   #promptSecret(String,boolean)
which is also used for the password.

One option is to change the signature of promptSecret into
   #promptSecret (String msg, String secretLabel, boolean includeLocation)
such that the "secretLabel" would specify what kind of secret is being 
prompted for. The problem here is that this relays into
   IUserAuthenticator
which doesn't provide this "secretLabel" support yet, and we'd thus need to 
make an API change involving IUserAuthenticator2 (Well it's likely we won't
get away without API changes anyways).
Comment 2 Martin Oberhuber CLA 2009-01-21 06:55:34 EST
Created attachment 123214 [details]
CVS passphrase dialog
Comment 3 Martin Oberhuber CLA 2009-01-21 06:59:44 EST
Created attachment 123215 [details]
CVS password dialog

The password dialog is shown when clicking CANCEL in the passphrase dialog; this is not obvious. Also, it's unclear why the password can be stored in secure storage but the passphrase can not.
Comment 4 Martin Oberhuber CLA 2009-01-21 07:18:58 EST
When asking for community help, could the Platform Team explain the relationship between jsch.UserInfo / IUserAuthenticator as well as the mechanics of caching the password in Equinox secure storage? I'm not quite sure at this time as to what would be the right approach getting this fixed.
Comment 5 Tomasz Zarna CLA 2011-01-20 12:55:10 EST
(In reply to comment #3)
> The password dialog is shown when clicking CANCEL in the passphrase dialog; this
> is not obvious. 

This is probably the same fallback you would see if you ssh'ed to the host with putty. When asked for the password and pressed enter, you would be asked for the password. I _guess_ this may depend on ssh daemon configuration.
Comment 6 Lars Vogel CLA 2019-09-24 13:50:12 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.