Bug 260757 - [key binding][content assist] Allow code-assist completion key to be configurable.
Summary: [key binding][content assist] Allow code-assist completion key to be configur...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 13:39 EST by Raxx Raxx CLA
Modified: 2019-09-06 16:10 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raxx Raxx CLA 2009-01-12 13:39:18 EST
Currently it would appear the code-assist completion key is hard-wired to be the enter key.  Would it be possible to make it configurable?  Or, at least, allow it to be switched between the enter and tab keys?

I find myself often having to remove assisted code because I wanted to type something and then enter an endline before typing the next token (usually for code-readability reasons) and the code assist has entered the suggested code on the current line.  Also, the code-assist window prevents me from simply pressing the down arrow to navigate out of it. (:

Anyway, I love Eclipse and would do it myself if given the chance, but I figure I'd have to be vetted on code edits before allowed to commit my changes.  Let me know if you'd like me to do it, though, and where I would go to get started contributing to the code base.

Thanks,
.Reg
Comment 1 Eric Moffatt CLA 2009-01-14 16:00:59 EST
Reginald, always nice to hear from someone who's actually interesting in helping us to fix an issue (rather than just reporting it...;-).

I've passed this on to the editor team for comments.
Comment 2 Dani Megert CLA 2009-01-15 03:28:43 EST
We won't work on this. Note that Tab is used to switch to the completion proposal window.

Having said that, if you want to provide a patch we're open to look at it. You would have to define commands for accepting a proposal (default: Enter) and for moving the focus to the proposal window (default: Tab).

Entry point to investigate is: org.eclipse.ui.texteditor.KeyBindingSupportForAssistant
Comment 3 Raxx Raxx CLA 2009-01-16 18:38:48 EST
Thanks, Eric and Dani!

I'll get to it as soon as I've finished some other work here.

As well, I have a question about using <tab> to switch to the completion window.  I'm wondering if there is some documentation (and if there is, I'll find it so don't worry about the question.)  And if not, is there any use to set the focus to the code-completion window?  When the window pops up it already catches the up and down arrow key presses and from what I can tell pressing <tab> to set the focus to the window doesn't allow me to do anything other than move up and down the entries using the up/down arrows.  Now, I'm using PDT for PHP development and perhaps in another perspective tabbing to the code-completion window would allow you to navigate some more options, but I've never seen it allow that.

I'll create bindings for both the commands and then we'll be able to go from there.

Thanks!
.Winston (My real name... (; )
Comment 4 Dani Megert CLA 2009-01-19 03:16:02 EST
> doesn't allow me to do anything  ther than move up and down the entries 
You can e.g. use Left/Right arrow key to shift the text if it is too wide. Also, once it has the focus you can use the mouse scroll wheel. Basically, you get everything that the OS supports for a focused list. Another reason is accessibility (screen reader support). Further more, a second Tab brings the focus to the additional info shell (again for accessibility reasons).
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:10:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.