Bug 260547 - implement folding in the WikiText editor
Summary: implement folding in the WikiText editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.0.0   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 260475
  Show dependency tree
 
Reported: 2009-01-09 09:51 EST by David Green CLA
Modified: 2011-01-06 10:01 EST (History)
0 users

See Also:

Attachments
partial implementation (7.97 KB, patch)
2009-01-09 12:08 EST, David Green CLA 		no flags Details | Diff
mylyn/context/zip (72.42 KB, application/octet-stream)
2009-01-09 12:08 EST, David Green CLA 		no flags Details
evolved implementation (31.51 KB, patch)
2009-01-12 13:13 EST, David Green CLA 		no flags Details | Diff
mylyn/context/zip (6.36 KB, application/octet-stream)
2009-01-12 13:13 EST, David Green CLA 		no flags Details
mylyn/context/zip (71.89 KB, application/octet-stream)
2009-01-12 23:22 EST, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2009-01-09 09:51:22 EST 
folding per "Folding in Eclipse Text Editors":http://www.eclipse.org/articles/Article-Folding-in-Eclipse-Text-Editors/folding.html
Comment 1 David Green CLA 2009-01-09 12:08:27 EST 
Created attachment 122131 [details]
partial implementation

implementation of folding with the following issues:

* folding annotations aren't created until the document is modified
* if a section is folded and the document is modified exceptions occur when applying the text presentation
Comment 2 David Green CLA 2009-01-09 12:08:30 EST 
Created attachment 122132 [details]
mylyn/context/zip
Comment 3 David Green CLA 2009-01-12 13:13:51 EST 
Created attachment 122303 [details]
evolved implementation

implementation appears to work, evolved with:

* toggle actions in the ruler context menu
* persistent preferences

has performance issue when toggling folding on large documents (eg: 10,000 lines)

MarkupEditor.updateProjectionAnnotations could do with some rework -- it doesn't perform too well and the code is ugly.
Comment 4 David Green CLA 2009-01-12 13:13:54 EST 
Created attachment 122304 [details]
mylyn/context/zip
Comment 5 David Green CLA 2009-01-12 23:22:34 EST 
implementation complete
Comment 6 David Green CLA 2009-01-12 23:22:38 EST 
Created attachment 122359 [details]
mylyn/context/zip