Bug 260452 - [Wizards] CVS GenerateDiffFileWizard duplicates code with Wizard from compare plugin
Summary: [Wizards] CVS GenerateDiffFileWizard duplicates code with Wizard from compare...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 71374
Blocks:
  Show dependency tree
 
Reported: 2009-01-08 16:04 EST by Kacper Zdanowicz CLA
Modified: 2019-09-06 16:13 EDT (History)
2 users (show)

See Also:

Attachments
patch of new GenerateDiffFileWizard (118.36 KB, patch)
2009-01-08 16:09 EST, Kacper Zdanowicz CLA 		no flags Details | Diff
some garbage removed from previous patch (112.76 KB, patch)
2009-01-08 16:14 EST, Kacper Zdanowicz CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Zdanowicz CLA 2009-01-08 16:04:52 EST 
Build ID: I20081211-1105

Steps To Reproduce:



More information:
While working on wizard for generating diff file from any comparison (bug 71374) we used a lot of code from previous GenerateDiffFileWizard from org.eclipse.team.cvs.ui plugin. As a result major duplication of code appeared. 

A superclass of wizard should be created and GenerateFileWizard in org.eclipse.team.cvs.ui should be a subclass of newly created wizard (bug 71374) to avoid code duplication.
Comment 1 Kacper Zdanowicz CLA 2009-01-08 16:09:51 EST 
Created attachment 122012 [details]
patch of new GenerateDiffFileWizard

This patch changes a GenerateDiffFileWizard from org.eclipse.team.cvs.ui plugin, so that it sublass a GenerateDiffFileWizard  from org.eclipse.compare plugin. Code duplication is avoided
Comment 2 Kacper Zdanowicz CLA 2009-01-08 16:14:17 EST 
Created attachment 122014 [details]
some garbage removed from previous patch
Comment 3 Tomasz Zarna CLA 2009-03-30 12:19:14 EDT 
Kacper, sorry for the late response. Could you please update the patch?
Comment 4 Tomasz Zarna CLA 2009-03-31 04:31:50 EDT 
I looked briefly at the patch file itself and the first change I saw was removing copyrights section from CVS' GenerateDiffFileWizard. Please review the patch one more time while updating it.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:13:04 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.