Bug 260294 - @Cache defaults shared to true, but parsing code default to false
Summary: @Cache defaults shared to true, but parsing code default to false
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-01-07 13:38 EST by James Sutherland CLA
Modified: 2022-06-09 10:31 EDT (History)
1 user (show)

See Also:


Attachments
Patch (843 bytes, patch)
2009-01-07 13:43 EST, James Sutherland CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Sutherland CLA 2009-01-07 13:38:01 EST
Our default shared setting in the annotation and xml is true.  However the code in CacheMetadata is incorrectly defaulting it to false if null.

In general none of the meta-data processing should be setting default values if null, null means use the default, which may be set elsewhere.

Please fix this for 1.1 if possible.
Comment 1 James Sutherland CLA 2009-01-07 13:43:17 EST
Created attachment 121845 [details]
Patch
Comment 2 James Sutherland CLA 2009-01-08 10:12:25 EST
I fixed the shared default bug, but the null defaulting needs to be fixed across the board.  I think it is only an issue from xml, as annotation do not support null, so will default correctly?
Comment 3 James Sutherland CLA 2009-01-12 09:55:01 EST
Part of the issue on defaulting is that annotation do not allow null, so the @Cache annotation needs to be change to use -1 default for size, and DEFAULT as default for type, not sure how to default shared other than changing type to tri-state from boolean.  Null should be maintained from XML though.

This causes the project level defaults for cache options to not default correctly.
Comment 4 James Sutherland CLA 2009-11-16 14:22:26 EST
The original issue was fixed.

And the general issue was resolved by switch to asm to process metadata, I think.
Comment 5 Eclipse Webmaster CLA 2022-06-09 10:31:30 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink