Community
Participate
Working Groups
Created attachment 121646 [details] Patch with the implementation An example combining informations and tricks implementing a: - native looking multi checkbox viewer - supports tabbing - ... The intial work used is the one from my blog including comments from people on the blog so maybe we need a CQ.
The initial code was always available from my companies public SVN repo a released there [1] and the comments [2] and [3]. We should also test on Win32 and GTK to see if the adjustments in the OwnerDrawLabelProvider are appropriate there. Boris do we need a CQ for this? I was told by Wayne that if the code was made public in a public area other than Eclipse (my own SVN-Repo) that we need a CQ (we also have contributors here [2] and [3]). [1]http://publicsvn.bestsolution.at/repos/java/at.bestsolution.jface/branches/3_3_support/src/at/bestsolution/jface/viewers/EmulatedNativeCheckBoxLabelProvider.java [2]http://tom-eclipse-dev.blogspot.com/2007/01/tableviewers-and-nativelooking.html#c5864843583641560752 [3]http://tom-eclipse-dev.blogspot.com/2007/01/tableviewers-and-nativelooking.html#c8984638995490184927
(In reply to comment #1) > Boris do we need a CQ for this? I was told by Wayne that if the code was made > public in a public area other than Eclipse (my own SVN-Repo) that we need a CQ > (we also have contributors here [2] and [3]). Yes, you should file a CQ through portal.eclipse.org. Let me know if you need help.
The CQ [1] is filled and I contact the commenter on my blog to ask him for confirmation. [1]https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2925
Created attachment 121831 [details] Revised
My comment on Toms blog contributed some improvements to his code. These improvements were written solely by me. So of course you can add this code to the Eclipse JFace Snippet Collection. Perhaps you could add a short comment that names me as a contributor, that would be great.
I did contribute a few lines. Is there anything in particular I need to do here?
Hi Alexander; if you could just confirm your answers to the following question on this bug would be great: 1. You authored the lines of code you contributed 100% 2. You have the rights to donate the content to Eclipse 3. You are submitting them to Eclipse under the EPL Thanks, Sharon Corbett Eclipse Intellectual Property
Absolutely. 1. I wrote the code that I contributed to this snippet 100%. 2. I have the rights to donate the content to Eclipse. 3. I am submitting the contribution to Eclipse under the EPL. Let me know if there is anything else you need.
FYI: the makeShot method is currently leaking since it needs to dispose the variables image and greenScreen.
btw, the CQ has been approved a while ago.
Released with some more tweaks for OS-X to CVS. We should discuss in whether we should probably push the Native-Combo-CellEditor implementation up to JFace.
this is not part of the release but the code is in the repo
I'm voting for this too be pushed into JFace proper. Its a neat solution to a common problem.
(In reply to comment #13) > I'm voting for this too be pushed into JFace proper. Its a neat solution to a > common problem. > +1
if you want that you'll need to file a new bug - I'm a bit worried on how the screenshot is take so we need to discuss with SWT-Team
(In reply to comment #15) > if you want that you'll need to file a new bug - I'm a bit worried on how the > screenshot is take so we need to discuss with SWT-Team > I raised bug 285121 - please vote for that one.
