Bug 259940 - [Viewers] Document providers are not used when comparing revisions from CVS
Summary: [Viewers] Document providers are not used when comparing revisions from CVS
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.2   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 223857
  Show dependency tree
 
Reported: 2009-01-05 05:41 EST by Pawel Pogorzelski CLA
Modified: 2009-06-02 07:08 EDT (History)
3 users (show)

See Also:
Mike_Wilson: pmc_approved+

Attachments
Patch_v01 (4.04 KB, patch)
2009-01-05 06:19 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2009-01-05 05:41:30 EST 
Build ID: Build id: N20081213-2000

Steps To Reproduce:
1. Open compare editor on revisions A and B from CVS Repositories view
2. Open revision A in an plain editor
3. Change encoding on revision A in the plain editor

Result:
4. Encoding change doesn't propagate to compare editor, panel containing revision A is not refreshed

More information:
This doesn't happen when comparing two java files and changing encoding on one of them in an different editor.
Comment 1 Pawel Pogorzelski CLA 2009-01-05 06:19:16 EST 
Created attachment 121521 [details]
Patch_v01

Patch to review.
Comment 2 Pawel Pogorzelski CLA 2009-01-05 08:57:26 EST 
Since the comment 0 applies only to text files that are not java files I'm changing the abstract.

Old abstract:
[Viewers] Encoding changes on remote revisions don't propagate to compare editor
New abstract:
[Viewers] Document providers are not used when comparing revisions from CVS Repositories view
Comment 3 Tomasz Zarna CLA 2009-01-06 07:25:08 EST 
Released to HEAD with some minor modifications.
Comment 4 Pawel Pogorzelski CLA 2009-01-08 09:05:19 EST 
This has to back-ported to the maintanance stream. Setting target milestone to 3.4.2.
Comment 5 Tomasz Zarna CLA 2009-01-12 07:37:20 EST 
The fix has been released to 3.4.x maintenance stream.