Bug 259710 - display context elements when task is activated
Summary: display context elements when task is activated
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P2 minor (vote)
Target Milestone: 3.1   Edit
Assignee: Hiroyuki CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 252461 259621 260665 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-27 09:16 EST by Hiroyuki CLA
Modified: 2009-02-24 03:46 EST (History)
5 users (show)

See Also:

Attachments
context_problem.patch (3.31 KB, patch)
2008-12-27 09:24 EST, Hiroyuki CLA 		no flags Details | Diff
context_problem_2nd.patch (5.15 KB, patch)
2009-01-05 06:45 EST, Hiroyuki CLA 		no flags Details | Diff
mylyn/context/zip (27.68 KB, application/octet-stream)
2009-01-18 23:51 EST, Steffen Pingel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroyuki CLA 2008-12-27 09:16:48 EST 
1) The deactived task which has context is opened with the Task Editor. 
2) The Context page of the Task Editor is displayed. 
3) The Active button in the toolbar of the Task Editor is clicked. 

The context element is not displayed even if  activated with the Context page.
The slider doesn't become enabled.

There is no problem when the actived task is  opened. 

I think that a necessary code is insufficient.
Comment 1 Hiroyuki CLA 2008-12-27 09:24:34 EST 
Created attachment 121270 [details]
context_problem.patch

It is a patch that corrects the problem.
There might be a case not considered. 

The initial value to display everything (as 0 ?)  was set to the slider.
Comment 2 Steffen Pingel CLA 2009-01-03 11:49:36 EST 
Marking minor: The current work around is to close and reopen the task editor page.

Shawn, you were working on a patch that allowed loading of contexts that are not active. That functionality would make this patch obsolete. Do you think your patch will be ready for 3.1? Otherwise I'll go ahead and apply this one.
Comment 3 Hiroyuki CLA 2009-01-05 06:45:15 EST 
Created attachment 121522 [details]
context_problem_2nd.patch

There was a problem that the exception is generated by dispose of CommonViewer. 
The hot fix is up-loaded again.
Comment 4 Steffen Pingel CLA 2009-01-07 00:22:54 EST 
*** Bug 259621 has been marked as a duplicate of this bug. ***
Comment 5 Steffen Pingel CLA 2009-01-12 01:19:51 EST 
*** Bug 260665 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Pingel CLA 2009-01-14 18:56:46 EST 
Thanks Hiroyuki. I'll review the patch and consider it for 3.1. We'll address loading of contexts for tasks that are not active in a future iteration.
Comment 7 Steffen Pingel CLA 2009-01-18 23:51:49 EST 
Great stuff! I have applied the patch with minor modifications. The common viewer is disposed when the task is deactivated. This is a slight optimization to avoid resource consumption if task editors are open in the background.
Comment 8 Steffen Pingel CLA 2009-01-18 23:51:55 EST 
Created attachment 122889 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2009-02-24 03:46:12 EST 
*** Bug 252461 has been marked as a duplicate of this bug. ***