Bug 259410 - Enhanced text compare
Summary: Enhanced text compare
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 169386
Blocks: 282985 49173 310818
  Show dependency tree
 
Reported: 2008-12-19 15:47 EST by Dani Megert CLA
Modified: 2019-11-27 07:32 EST (History)
6 users (show)

See Also:


Attachments
Initial patch (11.62 KB, patch)
2009-01-30 07:56 EST, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (61.04 KB, application/octet-stream)
2009-01-30 07:56 EST, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-12-19 15:47:44 EST
Not yet in HEAD.

Like enhanced Java compare we need to offer enhanced text compare.
Comment 1 Tomasz Zarna CLA 2009-01-07 06:16:16 EST
One of the missing features that are available in Java compare (bug 169386) but not in text compare is Delete Line (bug 250288), even though it's a text editor action. Fixing this bug should solve the confusion, the action will be available in both text and Java compare.
Comment 2 Tomasz Zarna CLA 2009-01-09 06:16:27 EST
Bug 223857 introduces a second version of an ITextEditor adapter[1] (the first one already exists in MergeSourceViewer[2]). Fixing this bug will remove both adapters and replace them with an embedded text editor(s).

[1] org.eclipse.compare.contentmergeviewer.TextMergeViewer.getTextEditorAdapter()
[2] org.eclipse.compare.internal.MergeSourceViewer.TextEditorAdapter
Comment 3 Szymon Brandys CLA 2009-01-14 09:39:24 EST
We should not forget that the issue described in bug 54940 is fixed for text compare too.
Comment 4 Tomasz Zarna CLA 2009-01-30 07:56:13 EST
Created attachment 124263 [details]
Initial patch

A text editor backed client of TextMergeViewer. 

Next steps: 
- merge it into TMV 
- remove all unnecessary duplications like Go to Line contribution
- remove all adapters like the result of getTextEditorAdapter
Comment 5 Tomasz Zarna CLA 2009-01-30 07:56:17 EST
Created attachment 124264 [details]
mylyn/context/zip
Comment 6 Szymon Brandys CLA 2009-03-06 05:29:00 EST
We don't plan to address it now. I'm removing the target milestone but we'll set more realistic one when we have feedback from anyone interested in fixing this.
Comment 7 Anton Lunev CLA 2010-04-13 09:37:30 EDT
(In reply to comment #6)
> We don't plan to address it now. I'm removing the target milestone but we'll
> set more realistic one when we have feedback from anyone interested in fixing
> this.

I'm also interested in fixing this. Very annoying bug.
Comment 8 Philipp Meister CLA 2012-10-04 06:50:54 EDT
I'm interested to fixing this, too.

Is the text comparer including the c compare viewer?
Comment 9 Lars Vogel CLA 2019-11-27 07:32:25 EST
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.