Bug 258592 - [Dialogs] Jface InputDialog could allow subclasses to add custom controls
Summary: [Dialogs] Jface InputDialog could allow subclasses to add custom controls
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-12 03:23 EST by Hitesh CLA
Modified: 2019-09-06 16:06 EDT (History)
1 user (show)

See Also:


Attachments
proposed change (1.75 KB, patch)
2008-12-12 03:23 EST, Hitesh CLA
no flags Details | Diff
Size change (933.62 KB, image/bmp)
2008-12-12 04:22 EST, Krzysztof Daniel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hitesh CLA 2008-12-12 03:23:31 EST
Created attachment 120287 [details]
proposed change

The Jface InputDialog could allow subclasses to add custom controls. A very common usecase is to have a checkbox/toggle below the text area (InputDialogWithToggle). Rewriting  InputDialog would be unnecessary code duplication. This could come in handy in other situations as well. Attaching the proposed change. The change is minimal and does not affect the look and feel of existing dialog.
Comment 1 Krzysztof Daniel CLA 2008-12-12 04:22:54 EST
Created attachment 120291 [details]
Size change

My concerns:
 * a patch introduces extra space if there is no custom control. Having in mind that we have space for error message, this looks weird
 * error message appears under the custom control, which is not under the validation control. This may be confusing.

This is caused by the fact that error message is displayed until the text - so I do not see a clean way in which this dialog could be extended about desired functionality.
Comment 2 Susan McCourt CLA 2009-07-09 18:20:19 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:06:10 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.