Bug 258264 - extra * added to editor after adding php-doc
Summary: extra * added to editor after adding php-doc
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: Other All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-12-10 06:28 EST by Gadi Goldbarg CLA
Modified: 2020-05-14 11:52 EDT (History)
6 users (show)

See Also:

Attachments
pactch solving the problem with extra * after the comment block (7.84 KB, patch)
2009-01-21 08:03 EST, Vadim Punski CLA 		no flags Details | Diff
Patch also solving the end of line case (7.26 KB, patch)
2009-01-22 08:50 EST, Vadim Punski CLA 		no flags Details | Diff
updated patch (7.26 KB, patch)
2009-01-25 11:33 EST, Vadim Punski CLA 		jacek.pospychala: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gadi Goldbarg CLA 2008-12-10 06:28:33 EST 
type
<?php
/**
 * echo << enter
 * 
 */ | << click enter here
* << added

(no close tag for php)
Comment 1 Vadim Punski CLA 2009-01-21 08:03:56 EST 
Created attachment 123226 [details]
pactch solving the problem with extra * after the comment block

Patch provided.
Please use this patch after the patch provided in 259484, comment 6.
It's a previous patch, included also here...
Comment 2 Vadim Punski CLA 2009-01-22 08:50:06 EST 
Created attachment 123370 [details]
Patch also solving the end of line case

The patch solves the problem when the comment block is at the end of file, and enter key pressed.
Comment 3 Roy Ganor CLA 2009-01-25 11:22:42 EST 
contributed by Vadim
Comment 4 Vadim Punski CLA 2009-01-25 11:33:02 EST 
Created attachment 123677 [details]
updated patch

fixed in trunk
Comment 5 Vadim Punski CLA 2009-01-25 11:39:15 EST 
Comment on attachment 123677 [details]
updated patch

non relevant
Comment 6 Gadi Goldbarg CLA 2009-02-02 06:56:48 EST 
Verified Fixed.
Tested on pdt-all-in-one
2.1.0M4
SDK-I200901300153

Kalin Yanev 
kalin.a@zend.com