Bug 2577 - [Standard Components] Property sheet: up/down arrow causes an internal error (1GGM4ZB)
Summary: [Standard Components] Property sheet: up/down arrow causes an internal error ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Randy Giffen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:39 EDT by Kevin Haaland CLA
Modified: 2001-11-13 16:29 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Haaland CLA 2001-10-10 22:39:07 EDT
@WSAD-0.9

GPD (7/9/01 4:16:33 PM) Created for Yamato:


prefix        test
name          179060
reference     
abstract      Properties:up/down arrow causes internal error
duplicate     

state         open                        priority                          
severity      3                           target                            
age           3                           due                               
product                         hasApar                           

compName      wsa.web.oti                 answer                            
release                                   symptom       io                  
envName       Win2K,WinNT                 phaseFound    cvt                 
level         705_1300-R09-R0             phaseInject                       

addDate       2001/07/06 20:42:22         assignDate    2001/07/09 03:30:01 
lastUpdate    2001/07/09 03:30:01         responseDate                      
endDate                                

ownerLogin    decandio                    originLogin   jl09484             
ownerName     George DeCandio             originName    Tsukakoshi, Nobuyuki
ownerArea     9ZVA                        originArea    R1B00               

apar                                      pmr                          
test                                                                                               

tracks: none.

verify: none.

history:
    addDate              action          userLogin (userName)
    -------------------- --------------- ----------------------------------
    2001/07/06 20:42:22  open            jl09484 (Tsukakoshi, Nobuyuki)
    2001/07/06 20:43:10  assign          jl09484 (Tsukakoshi, Nobuyuki)
    2001/07/09 03:30:01  assign          hiromi (Hagiwara, Hiromi)

duplicate defects: none.

duplicate features: none.

sizing: none.

notes:
    <Note by jl09484 (Tsukakoshi, Nobuyuki), 2001/07/06 20:42:22, seq: 1 rel: 0  action: open>
.* CMVC Problem Description Form for Eclipse Studio V4.1

Abstract : Properties:up/down arrow causes internal error

Component : Properties View

Problem Description : Up and down arrow key causes internal error if the cursor on the field which has multiple predefined value

Misc. Information :
  Reported by :  Y. Yamanashi

  Date :  07/03/2001 (mm/dd/yyyy)
  Frequency :  S  ("S"olid / "I"ntermittent problem)

  Environment :
    OS : Windows 2000 & Windows NT
    Eclipse build : wsa-jdk-20010702_1300-R09-R09
                       wsa-jdk-20010705_1300-R09-R09 (tested on 07/07/2001)

  Re-creation Proc. :
    1. create a new HTML file and show it on Design view, and show Properties view
    2. enter text "sample" then you can see align on the Properties view
    3. click the value field of the align on the Properties view then press down arrow key
    4. then Internal error causes

       following is the log of this error ;

org.eclipse.swt.SWTException: Widget is disposed
       at org.eclipse.swt.SWT.error(SWT.java:1708)
       at org.eclipse.swt.SWT.error(SWT.java:1642)
       at org.eclipse.swt.widgets.Widget.error(Widget.java:368)
       at org.eclipse.swt.widgets.Control.getDisplay(Control.java(Compiled Code))
       at org.eclipse.swt.widgets.Widget.isValidThread(Widget.java(Compiled Code))
       at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java(Compiled Code))
       at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:617)
       at org.eclipse.swt.custom.CCombo.textEvent(CCombo.java:906)
       at org.eclipse.swt.custom.CCombo$1.handleEvent(CCombo.java:65)
       at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code))
       at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:622)
       at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1098)
       at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:980)
       at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:639)
       at org.eclipse.ui.internal.Workbench.run(Workbench.java:622)
       at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:815)
       at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285)
       at java.lang.reflect.Method.invoke(Native Method)
       at org.eclipse.core.launcher.Main.basicRun(Main.java:119)
       at org.eclipse.core.launcher.Main.run(Main.java:401)
       at org.eclipse.core.launcher.Main.main(Main.java:274)

    <Note by jl09484 (Tsukakoshi, Nobuyuki), 2001/07/06 20:43:10, seq: 2 rel: 0  action: assign>
Old Owner: asahata
New Owner: hiromi



    <Note by hiromi (Hagiwara, Hiromi), 2001/07/09 03:30:01, seq: 3 rel: 0  action: assign>
This seems to occur because it accesses to the combobox on Properties view even though the combobox been already disposed...
Could you please report this problem to OTI?
Thank you.
Old Component: wsa.web.pageediting
New Component: wsa.web.oti





NOTES:

GDA (7/11/01 10:55:48 AM)
	from wsad

6.  Property sheet: up/down arrow causes an internal error
   (1GGM4ZB: ITPJUI:ALL) This is an exception when arrow keys are used in a
   combo cell editor.  It is a very visible bug that should not be hard to
   fix.

ARCH (7/11/01 10:55:53 AM)
	Fix for 1.0

RG (7/16/01 10:27:09 AM)
	
Issues:
1. The html element is clearing its property descriptors when it is edited (either in the 
html editor or via the property sheet). When a new value is set in the property sheet the
property sheet will refresh the descriptors and in this case it is getting a new descriptor
for the property being edited. Since the descriptor provides the cell editor the old 
cell editor is being disposed which leads to the problem.

In general 
a) Property souces should not replace the descriptor being edited in the property sheet.
It is valid to add or remove other descriptors when a value changes but we do not
expect to lose the descriptor whose value is being changed.
b) The property sheet should be refreshed if the descriptors change as a result of a change
made via the resource editor (ex. html editor). 

2. The combo box cell editor is firing an applyEditorValue with every selection in the 
the combo box list. It should only be doing this when the user makes a "real" selection.
Simply navigating the list should not not cause an applyEditorValue.

NE (07/16/01 2:07:02 PM)
	Advised GPD to change client code.

RG (7/17/01 3:35:17 PM)
	Re 2. above, in order to fix this we need:
	1GH0W4N: SWT:ALL - DCR: CCombo should fire a default selection event
	We currently have no way to tell if a selection in the combo is a "real"
	selection (enter key or mouse click) or a selection simply caused by 
	scrolling through the list.

GDA (8/1/01 4:26:42 PM)
	Is GDC changing his code ? Is this closed from his perspective?
	Are we awaiting the fix mentioned above from swt & planning to make our fix and theirs for 1.0.
	Does swt know the above is required to address this fully.

DMW (8/2/2001 1:37:18 PM)
	I have reopened the defect from our (WSAD) side. The suggestions above seem reasonable, 
 	so we'll look at solving using those. I will report back what we find.

NE (8/2/01 1:49:16 PM)
	DMW adds:
		I don't know enough off the top of my head to know if the 2
		recommendations/issues can be solved on our side, but seems fairly likely.
		I would appreciate the issue remain "open" until we know for sure.

RG (8/3/01 1:23:01 PM)
	In org.eclipse.swt.custom.CCombo.textEvent(Event) a single SWT.KeyDown event is generating
	two callbacks to the listeners. I think SWT should check to see of the widget is disposed after
	issuing the first callback.
	The following change prevents the problem

				if (oldIndex != getSelectionIndex ()) {
					Event e = new Event();
					e.time = event.time;
					notifyListeners(SWT.Selection, e);
					// If widget has been disposed, return
					if (isDisposed())
						return;
				}

	Entered 1GHWA19: SWT:WINNT - Problem with callbacks from CCombo


KH (8/14/2001 1:51:35 PM)
	
	From GPD

Greg, Kevin-

The workaround for this PR is fine with us.  Sorry for the delay in getting
you this answer.

Thanks.
George.
---------------------- Forwarded by George DeCandio/Raleigh/IBM on
08/13/2001 06:21 PM ---------------------------

From: Nobuyuki Tsukakoshi@IBMJP on 08/10/2001 10:17 AM

To:   George DeCandio/Raleigh/IBM@IBMUS
cc:
From: Nobuyuki Tsukakoshi/Japan/IBM@IBMJP
Subject:  Re:  (Document link: George DeCandio)

George-san,
It seems ok.  I got same feeling from Harumi-san, too.

Best Regards,
---------------------------------------
Nobuyuki Tsukakoshi
Solution Quality,
Solution Business Development, IBM Japan, Ltd.
Tel    : +81-46-215-2706
Fax    : +81-46-273-7377
E-mail : JL09484@jp.ibm.com
---------------------------------------


From: George DeCandio@IBMUS on 2001/08/09 05:20

To:   Nobuyuki Tsukakoshi/Japan/IBM@IBMJP
cc:
From: George DeCandio/Raleigh/IBM@IBMUS
Subject:


Tsukakoshi-san-

OTI has add a workaround to the subject PR.  Can you please let me know if
this is suitable for you?

The PR text is appended at the end of this note.

Thanks.
George.

Abstract : Properties:up/down arrow causes internal error

Component : Properties View
Comment 1 DJ Houghton CLA 2001-10-29 19:01:51 EST
PRODUCT VERSION:
	R09, Win2000

Comment 2 Kevin Haaland CLA 2001-11-13 13:27:09 EST
Pls confirm that this fix made it into the 2.0 stream.
Comment 3 Randy Giffen CLA 2001-11-13 13:51:44 EST
Verified that SWT fix is present in the 2.0 stream
CCombo.textEvent
Comment 4 Kevin Haaland CLA 2001-11-13 16:29:31 EST
Fixed