Bug 257598 - [CommonNavigator] Missing capabilities support for actions provided by the CNF
Summary: [CommonNavigator] Missing capabilities support for actions provided by the CNF
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-04 14:01 EST by Brian Fitzpatrick CLA
Modified: 2009-03-09 13:21 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Fitzpatrick CLA 2008-12-04 14:01:13 EST
Hi there...

After discussing this with Francis a bit on the newsgroup, it appears that there may be some missing hooks for the Common Navigator Framework (CNF) to work with the Capabilities/Activities functionality that is being required by the Galileo release train. 

My simple capability filter takes care of 90% of all menu items (contributed using popup menu contributions, etc), views, and perspectives. But it doesn't seem to catch those few menus provided by the action providers.

There may be code changes required on my side in DTP as well as within the CNF action provider framework, but I'm willing to do that. I'm guessing it could either filter out actions by ID or filter out action providers by ID. Action providers would be my preference, as that would not require additional code changes on my side, but I'm good with whatever you guys decide to do here.

Thanks in advance. 
--Fitz
Comment 1 Francis Upton IV CLA 2009-03-07 03:12:41 EST
Well, I put in the capability of filtering by action (I added a method to CommonActionProvider to make it easy to filter and consider the plugin id associated with the action), and then I realized that I could also filter by the entire action provider, so I did that too.  So if you have your activityPatternBinding find the id of an actionProvider, then you are good.

Released to HEAD N20090307-2000, 35M6
Comment 2 Brian Fitzpatrick CLA 2009-03-09 13:21:03 EDT
Thanks Francis!