Bug 256924 - [About] About dialog text - Add capability to read system properties
Summary: [About] About dialog text - Add capability to read system properties
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4.2   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on: 172692
Blocks:
  Show dependency tree
 
Reported: 2008-11-28 12:55 EST by Kim Horne CLA
Modified: 2009-01-22 13:57 EST (History)
4 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2008-11-28 12:55:15 EST 
+++ This bug was initially created as a clone of Bug #172692 +++

Currently, the product's About dialog can insert strings specified in the about.mappings file.  It would be useful if system properties can be specified in the about.mappings file as well, in case the client needs to display information more dynamically at runtime (which we have found to be necessary for our product). 

In diving into eclipse code, it looks like a change like this will only affect org.eclipse.ui.internal.ProductProperties.java.  I have a working fix that I could suggest shortly if you agree this would be a beneficial enhancement.
Comment 1 Kim Horne CLA 2008-11-28 12:56:34 EST 
Paul, could I get a +1 on the last patch from the dependent bug?  You'll need to tweak the patch slightly - it's trying to apply to org.eclipse.ui.workbench_eclipse.
Comment 2 Paul Webster CLA 2008-11-28 13:42:41 EST 
That code looks simpler and will replace the properties every time.

PW
Comment 3 Kim Horne CLA 2008-11-28 13:54:00 EST 
Fix in HEAD.
Comment 4 Paul Webster CLA 2009-01-22 13:57:14 EST 
In M20090121-1700
PW