Bug 256821 - Activity diagram presents duplicated/corrupted elements
Summary: Activity diagram presents duplicated/corrupted elements
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EPF (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shilpa Toraskar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-27 13:21 EST by Isabela CLA
Modified: 2023-02-16 16:17 EST (History)
1 user (show)

See Also:


Attachments
Duplicated elements by big diagrams (20.27 KB, image/jpeg)
2008-11-27 13:21 EST, Isabela CLA
no flags Details
"Big diagram" (154.02 KB, image/jpeg)
2008-12-03 05:48 EST, Isabela CLA
no flags Details
Test Project with plug-in where the error occurs (59.68 KB, application/x-zip-compressed)
2008-12-03 10:22 EST, Isabela CLA
no flags Details
Repeated Corrupted Icons (182.59 KB, image/jpeg)
2008-12-03 10:23 EST, Isabela CLA
no flags Details
New Diagram without nodes which replaces the corrupted one (177.83 KB, image/jpeg)
2008-12-03 10:24 EST, Isabela CLA
no flags Details
Test Project 2 with plug-in where the error occurs (70.28 KB, application/x-zip-compressed)
2008-12-03 10:38 EST, Isabela CLA
no flags Details
Error trying to delete corrupted flow (103.58 KB, image/jpeg)
2008-12-03 10:38 EST, Isabela CLA
no flags Details
Correct.jpg (112.59 KB, image/jpeg)
2008-12-03 14:51 EST, Shilpa Toraskar CLA
no flags Details
Original.jpg (109.37 KB, image/jpeg)
2008-12-03 14:51 EST, Shilpa Toraskar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Isabela CLA 2008-11-27 13:21:41 EST
Created attachment 118940 [details]
Duplicated elements by big diagrams

Build ID: 20080821-1745 but also happens in 1.5.0.1

Steps To Reproduce:
1. Use a big diagram from a capability pattern
2. Create new activity
3. Create new nodes and flows
4. The nodes are duplicated and corrupted, because cannot be deleted properly
5. The flows are duplicated/corrupted
6. It is not possible to create some connections


More information:
This problem is related to closed bug 245981.

Another failure report regarding duplicated items in the activity diagram.

The numbers are shown in the picture attached.

1) New activities inserted without problems, but when trying to connect them with other elements, a duplicated control flow is created.

2) Nodes are also created duplicated/corrupted

3) trying to delete the duplicated node (or flow), only one of them is deleted, and the other is transformed in an element which point to the capability pattern or activity from which the diagram is. Trying to delete this element, EPF deletes the capability pattern or activity.

4) some connections are not allowed to be done, even being normal connections between activities.

It normally happens in capability patterns which contains a big number of activities inside it.

I don't know how to avoid it, I only try to make diagrams with fewer activities. In some cases I delete the diagram and create a new one... but for big/complex diagrams it is not a so easy decision.

I am using version 1.5.0, already tried the 1.5.0.1 and the problem persists.

I cannot send the project I am using, because of copyright in the company, but I will try to create a base where the problem happens and attach it later.
Comment 1 Isabela CLA 2008-11-28 07:51:51 EST
Also related to bug 246898.
Comment 2 Bingxue Xu CLA 2008-12-01 14:16:06 EST
Please investigate this first.
Comment 3 Shilpa Toraskar CLA 2008-12-01 16:39:57 EST
Some comments -

245981 - That corresponding user could not reproduce this issue again, so it could have been data specific, may be specific to one activity. That's why it was closed.

246898 - this bug reports about activity detail diagram (ADD). You are facing a issue with activity diagram. Those are 2 different diagrams and implementation is totally different. So this bug 256821 can NOT be related to 246898.


Some Questions - 
1. What do you mean by "big diagram" in step 1.
2. Are you able to reproduce this with lot of activity diagrams OR just one diagram ?
3. Is it extended activity (green) OR base activity (black) ?
4. If you restart EPF and then try to delete one of the node, what happens.

Being said all that, I tried running your steps, and I can't reproduce this. It could be very activity-specific. And I am afraid that we may need some data (plugins) in order to reproduce it. 

Comment 4 Isabela CLA 2008-12-03 05:48:49 EST
Created attachment 119363 [details]
"Big diagram"

ANSWERS:

1. What do you mean by "big diagram" in step 1...

As in the picture, I consider "big diagrams", diagrams with about 10 activities and lots of control flows and nodes.
I also have a lot of capability patterns in the Processes.

2. Are you able to reproduce this with lot of activity diagrams OR just one
diagram ?

Yes, I can reproduce this in many diagrams.

3. Is it extended activity (green) OR base activity (black) ?

In base activities.

4. If you restart EPF and then try to delete one of the node, what happens.

The node is deleted, but the other (second) node is converted in the capability pattern, and if I try to delete the second node, EPF tries to delete the capability pattern.

I will try to create a project where the problem is reproduceable to send to you.
Thanks.
Comment 5 Isabela CLA 2008-12-03 10:22:16 EST
Created attachment 119385 [details]
Test Project with plug-in where the error occurs

So, I did to general examples where the errors occurs.

TEST PROJECT:

In this plug-in, there are some error in the activity diagram of the capability pattern "RDI Processes"  -> Activity "Integration".

Here, as shown in the next attachment, the diagram created automatically 6 icons with the name of the Activity, if you try to delete one of them from inside the diagram, EPF deletes the entire activity.

The other attachment shows a diagram with was corrupted and looses all the nodes created manually.
Comment 6 Isabela CLA 2008-12-03 10:23:26 EST
Created attachment 119386 [details]
Repeated Corrupted Icons
Comment 7 Isabela CLA 2008-12-03 10:24:21 EST
Created attachment 119387 [details]
New Diagram without nodes which replaces the corrupted one
Comment 8 Isabela CLA 2008-12-03 10:38:09 EST
Created attachment 119388 [details]
Test Project 2 with plug-in where the error occurs

TEST PROJECT 2:

Here a activity diagram with corrupted nodes and control flows can be seen.

RDI Requirements and Design Processes -> Activity diagram
-> In the right bottom of the diagram area are the corrupted elements.


To create new corrupted nodes, try to create many nodes and activities into a big diagram. EPF begins to create duplicated nodes and flows.
If one of the duplicated flow/node is deleted, one corrupted flow remains. (see next attachment).

If you exit EPF and enters again, you must first create some element until the error occurs again.

I observed this problems only in diagrams where many nodes/flows where manually included.
Comment 9 Isabela CLA 2008-12-03 10:38:47 EST
Created attachment 119389 [details]
Error trying to delete corrupted flow
Comment 10 Shilpa Toraskar CLA 2008-12-03 14:49:39 EST
On Comment #5 -
[Isabela <veronica.quandt@gmail.com>] Here, as shown in the next attachment, the diagram created automatically 6icons with the name of the Activity, if you try to delete one of them from inside the diagram, EPF deletes the entire activity.

>>>> EPF created diagram automatically from WBS structure with name of activity. And when you try to delete activity node from the diagram, EPF will delete the that activity itself. This is expected behavior. When you are deleting an activity node from the diagram, it's just NOT ui node, it will delete the activity. Its by design.

On Comment #6 -
I would like to know how you got corrupted diagram. I see the diagram is corrupted but I want to know how it went to that step. 

On Comment #7
That's new diagram EPF generated by default based on WBS nodes and predecessor relationships

On Comment #8 & #9
I did take Test Project 2. I deleted the diagram on RDI Requirements and Design since it was already corrupted. I tried to draw the similar diagram what you were trying (I hope). Attached is the diagram.  Steps I did
1. Delete the diagram
2. Open the diagram again, EPF has created the automatic diagram as you showed in #7. 
3. At this point i deleted all control flows since in your diagram you have lot of fork/join nodes. 
4. Then I started placing all fork/join nodes in the diagram. And you can see resulting diagram in attachment. It did not lead to any corruption. I can save/reopen that diagram fine. Correct Diagram attached - Correct.jpg

One thing I noticed in your original Test Project 2->RDI Requirement and Desing activity diagram, you have one fork/join node which is very confusing. Marked in Original.jpg. How did you get this node with multiple incoming and outgoing control flows. Is this diagram migrated from EPF 1.0/1.2 (older version of EPF). In EPF 1.5, we strictly block to draw multiple incoming and outgoing connections sticking with UML conventions. In older version, we didnt have that rule and you could draw it. 

I tried hard to corrupt the diagram but I couldn't. That doesn't mean it's not possible. There could be certain user actions which is leading to diagram corruption in your case, and we would like to nail those. So if any steps you could provide would be helpful.
Also - was the diagram migrated from older version of EPF.
1. Was there any tampering on xmi files directly ?

Comment 11 Shilpa Toraskar CLA 2008-12-03 14:51:12 EST
Created attachment 119420 [details]
Correct.jpg

Diagram I created on your project by deleting and restarting
Comment 12 Shilpa Toraskar CLA 2008-12-03 14:51:52 EST
Created attachment 119421 [details]
Original.jpg

Your original diagram with questionable fork/join node
Comment 13 Bingxue Xu CLA 2008-12-17 00:21:17 EST
please try the latest 1.5.0.2 build on 2008-12-12, and let us know the result.
Comment 14 Isabela CLA 2009-01-05 11:30:07 EST
(In reply to comment #10)

To the questions:

- The fork/join node which is very confusing is in fact a composition of a join together with a fork node. 
- Yes, the diagram is migrated from older versions of EPF, but by creating new big diagrams the same happens.  
- There was no tampering on xmi files directly.

- I willl try the new build (1.5.0.2) this week.
Comment 15 Isabela CLA 2009-01-08 06:49:16 EST
The problem remains (in build 1.5.0.2) when modifying big diagrams which were created initially in older versions of EPF. When deleting old diagram and creating new one, the problem cannot be reproduced easily.