Bug 256396 - Duplicated code in Team's compare actions
Summary: Duplicated code in Team's compare actions
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 RC1   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2008-11-25 04:39 EST by Tomasz Zarna CLA
Modified: 2010-05-07 11:12 EDT (History)
0 users

See Also:
tomasz.zarna: review+

Attachments
Proposal v01 (10.86 KB, patch)
2010-05-07 08:52 EDT, Szymon Brandys CLA 		no flags Details | Diff
Fix v02 (10.81 KB, patch)
2010-05-07 10:03 EDT, Szymon Brandys CLA 		no flags Details | Diff
Alternative fix v03 (10.36 KB, patch)
2010-05-07 10:24 EDT, Szymon Brandys CLA 		no flags Details | Diff
Fix v04 (10.81 KB, patch)
2010-05-07 10:43 EDT, Szymon Brandys CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-11-25 04:39:32 EST 
The piece of code responsible for finding a reusable editor is the same in OpenInCompareAction and CompareRevisionAction. The classes may have more overlapping methods and there might be more actions that could reuse the same code. We should move the code to one place for easier maintenance, it could be either common superclass, an utility class, the TeamUI class or any other place.
Comment 1 Szymon Brandys CLA 2009-04-09 10:49:05 EDT 
Sorry, no time... 3.6.
Comment 2 Szymon Brandys CLA 2010-05-07 08:52:44 EDT 
Created attachment 167460 [details]
Proposal v01
Comment 3 Szymon Brandys CLA 2010-05-07 10:03:55 EDT 
Created attachment 167475 [details]
Fix v02
Comment 4 Szymon Brandys CLA 2010-05-07 10:24:45 EDT 
Created attachment 167478 [details]
Alternative fix v03
Comment 5 Szymon Brandys CLA 2010-05-07 10:43:21 EDT 
Created attachment 167485 [details]
Fix v04
Comment 6 Tomasz Zarna CLA 2010-05-07 11:10:27 EDT 
Looks good to me.
Comment 7 Szymon Brandys CLA 2010-05-07 11:12:49 EDT 
Fix v04 checked in to HEAD.