Bug 256340 - [Contributions] Allow switching between icon and icon and text mode for commands
Summary: [Contributions] Allow switching between icon and icon and text mode for comm...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-11-24 16:33 EST by Penka CLA
Modified: 2012-04-05 11:03 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Penka CLA 2008-11-24 16:33:36 EST 
Add
public void setMode(int mode) 
method to the CommandContributionItem API to allow dynamic setting of the display mode - icon or icon and text.

We have a toggle toolbar text feature in our application and the lack of this functionality for commands is preventing us from migrating our existing actions to commands. Is it possible this enhancement to be included in future 3.4.x build?
Comment 1 Paul Webster CLA 2008-11-25 08:03:22 EST 
I'm not keen on this, as the client code can't find most CommandContributionItems in the first place (except for ones they instantiate, maybe).  But maybe it wouldn't really hurt anything either, keeping in mind that setMode(*) would not refresh anything, that would be the client code job.

That being said, no new API is allowed in 3.4.x, it would have to be in 3.5

PW
Comment 2 Ravikanth Somayaji CLA 2012-04-05 06:43:33 EDT 
Not in in 3.5 as well? 

I'd be happy to have this - at the moment I have to set the mode by reflection which is slightly a pain. Kindly let know when this will go into the API.

Thanks,
Comment 3 Paul Webster CLA 2012-04-05 11:03:12 EDT 
No one is looking at this at the moment, but patches are welcome.

http://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW