Bug 256269 - Changing property from Binary to Ascii (-ko) did commit pending changes as well
Summary: Changing property from Binary to Ascii (-ko) did commit pending changes as well
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-24 08:06 EST by Philipe Mulet CLA
Modified: 2019-09-06 16:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2008-11-24 08:06:49 EST 
3.5M3

I was working on a large change, which did in particular touch one file Foo.java. This one file was (by mistake) tagged as Binary in CVS.

Using the wizard Team>Change ASCII/Binary property; I was able to make it become Ascii(-ko), BUT at the same time it performed the change, it actually committed the pending change for this unit !??

This means HEAD has been made inconsistent, since unanticipated changes got committed as a result of the property change.

For such an operation, it should copy modified contents aside, fetch the HEAD contents, apply the property change, then resurrect my modified contents.
Comment 1 Dani Megert CLA 2010-10-15 02:35:21 EDT 
Just happened to me today as well. Committing code as a side effect is not good.
Comment 2 Eclipse Webmaster CLA 2019-09-06 16:05:52 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.