Community
Participate
Working Groups
Machine names are invalid in generated performance results of nightly build N20081120-2000. They show machine internal name as epwin2, eplnx1 or eplnx2 instead of full describing names, respectively: - Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM) - SLED 10 Sun 1.50_10 (2 x 3.00GHz - 3GB RAM) - RHEL 5.0 Sun 1.6_04 (2 x 3.00GHz - 3GB RAM)
I cannot reproduce this issue locally using following parameters for the generation: -current I20081202-1812 -jvm sun -config epwin2,eplnx1,eplnx2 -config.properties "epwin2,Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1,SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2,RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)" -scenario.pattern org.eclipse.%.test% -dataDir d:/tmp/data/v35 -output d:/tmp/apache/I20081202-1812 -print So, it seems that the problem comes from the arguments defined in eclipse/helper.xml: -current ${buildId} -jvm ${eclipse.perf.jvm} -print -output ${postingDirectory}/${buildLabel}/performance/ -config epwin2,eplnx1,eplnx2 -config.properties ${eclipse.perf.config.descriptors} -dataDir ${postingDirectory}/../../data/v35 -scenario.pattern org.eclipse.%.test%" /> with: <property name="eclipse.perf.config.descriptors" value="Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM), SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM), RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)" /> I think that the value for eclipse.perf.config.descriptors should be instead: <property name="eclipse.perf.config.descriptors" value="epwin2, Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1, SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2, RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)" />
Released for 3.5M4 in HEAD stream...
I've tagged the builder and am running a test build for other changes today. So it should be included in tonight's build.
(In reply to comment #3) > I've tagged the builder and am running a test build for other changes today. So > it should be included in tonight's build. > Thanks :-)
Unfortunately, that still does not work :-(
The output is: Parameters used to generate performance results (12/12/08 3:12 AM): -current = I20081211-0100 -jvm = sun -print (to the console) -output = /builds/transfer/files/master/downloads/drops/I20081211-0100/performance/ -config = epwin2,eplnx1,eplnx2 -config.properties = -dataDir = /builds/transfer/files/master/downloads/drops/../../data/v35 -scenario.pattern = org.eclipse.%.test% + no baseline specified => use last one: R-3.4-200806172000_200812101433 Kim, do you see any reason why the ${eclipse.perf.config.descriptors} is empty although it's set 3 lines above in eclipse/helper.xml file: <property name="eclipse.perf.config.descriptors" value="epwin2, Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1, SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2, RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)" /> ? Note that this property was not set the same way in 3.4 as this line didn't exist. Do you know why has it been added there?
I think I found the explanation: looking at ref35.properties file in /home/users/releng/buildTools/eclipse.perf, the eclipse.perf.config.descriptors property is defined as follow: eclipse.perf.config.descriptors="eclipse.perf.config.descriptors" value="Win XP Sun 1.5.0_10 (2 x 3.00GHz, 3GB RAM), SLED 10 Sun 1.50_10 (2 x 3.00GHz, 3GB RAM), RHEL 5.0 Sun 1.6_04 (2 x 3.00GHz, 3GB RAM)" This was not valid; its value should be something like: "config1,descriptor1; config2,descriptor2; <etc.>" Note that descriptors should not contain any comma nor semi-colon! I've changed it to: eclipse.perf.config.descriptors="eclipse.perf.config.descriptors" value="epwin2,Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1,SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2,RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)"
(In reply to comment #7) > I think I found the explanation: looking at ref35.properties file in > /home/users/releng/buildTools/eclipse.perf, the eclipse.perf.config.descriptors > property is defined as follow: > > eclipse.perf.config.descriptors="eclipse.perf.config.descriptors" value="Win XP > Sun 1.5.0_10 (2 x 3.00GHz, 3GB RAM), SLED 10 Sun 1.50_10 (2 x 3.00GHz, 3GB > RAM), RHEL 5.0 Sun 1.6_04 (2 x 3.00GHz, 3GB RAM)" > > This was not valid; its value should be something like: > "config1,descriptor1; config2,descriptor2; <etc.>" > Note that descriptors should not contain any comma nor semi-colon! > > I've changed it to: > eclipse.perf.config.descriptors="eclipse.perf.config.descriptors" > value="epwin2,Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1,SLED 10 Sun > 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2,RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB > RAM)" > My last change was obviously invalid. This is a .properties file, not an Ant one, hence this property should be defined as: eclipse.perf.config.descriptors="epwin2,Win XP Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx1,SLED 10 Sun 1.5.0_10 (2 x 3.00GHz - 3GB RAM); eplnx2,RHEL 5.0 Sun 6.0_04 (2 x 3.00GHz - 3GB RAM)" So, I guess this time it should work!
Verified for 3.5M5 using build I20090127-0100
