Bug 255709 - [Commands] Generify org.eclipse.core.commands.State
Summary: [Commands] Generify org.eclipse.core.commands.State
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-18 15:07 EST by Gary Gregory CLA
Modified: 2013-06-05 10:41 EDT (History)
1 user (show)

See Also:


Attachments
Java source. (3.93 KB, text/x-java)
2008-11-18 15:07 EST, Gary Gregory CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Gregory CLA 2008-11-18 15:07:51 EST
Created attachment 118186 [details]
Java source.

Please "generify" org.eclipse.core.commands.State. A generics version of the class is attached. Note that the interface org.eclipse.core.commands.IStateListener also needs to be changed to:

public interface IStateListener {

	/**
	 * Handles a change to the value in some state.
	 * 
	 * @param state
	 *            The state that has changed; never <code>null</code>. The
	 *            value for this state has been updated to the new value.
	 * @param oldValue
	 *            The old value; may be anything.
	 */
	public void handleStateChange(State<T> state, Object oldValue);
}

I'm not sure how far this trickles down...
Comment 1 Prakash Rangaraj CLA 2008-11-19 04:13:36 EST
The compiler compliance of the entire platform is 1.4. No generics :-(
Comment 2 Gary Gregory CLA 2008-11-19 15:21:47 EST
Ah, yes, I see: http://www.eclipse.org/eclipse/development/readme_eclipse_3.4.html

Is there a plan for moving to Java 5 in general?

Thanks you.
Comment 3 Paul Webster CLA 2008-11-21 12:28:34 EST
There are no plans to do java 5 at the moment, but it is being considered for the e4 work

PW
Comment 4 Dani Megert CLA 2013-06-05 10:41:38 EDT
Removing outdated target milestone.