Bug 255447 - [CellEditors] DecoratingStyledCellLabelProviderTest appears to leak TextLayout
Summary: [CellEditors] DecoratingStyledCellLabelProviderTest appears to leak TextLayout
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2008-11-16 01:57 EST by Remy Suen CLA
Modified: 2009-03-12 05:20 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2008-11-16 01:57:34 EST 
In the CountryEntry inner class's drawName(Event) method, we create a new TextLayout but we never call dispose() on it. I would've marked this as being major but since it's in our tests and not in our real code, it's not _as_ critical.
Comment 1 Eric Moffatt CLA 2008-11-24 11:17:46 EST 
Steve, I can't find a 'dispose' method...should I use 'destroy' instead?

Perhaps we should add one since the jdoc says I should be 'dispos'ing this...
Comment 2 Steve Northover CLA 2008-11-24 11:23:44 EST 
Eh?  There should be a TextLayout.dispose(). We talking about something else?
Comment 3 Dani Megert CLA 2009-02-17 10:03:30 EST 
I came across this when looking into StyledString and its label providers. Let me fix this.
Comment 4 Dani Megert CLA 2009-02-17 10:08:01 EST 
Fixed in HEAD.
Available in builds >= N20090217-2000.
Comment 5 Dani Megert CLA 2009-03-12 05:20:28 EDT 
Verified in I20090312-0100.