Description Morten Hindsholm 2008-11-12 05:02:18 EST

I am developing a connector, and I think I might have spotted a minor bug.
 
My backend requires a login, but it is legal to have an empty password.

However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks
- via the private method isMissingCredentials() - against empty passwords.

This means that I cannot easily implement isPageComplete() in my
RepositorySettings class which extends AbstractRepositorySettingsPage,
because I cannot call super.isPageComplete() with an empty password, and I
also cannot bypass AbstractRepositorySettingsPage and call
isPageComplete() in its superclass AbstractTaskRepositoryPage. If you
understand...
 
I think a reasonable fix would be to make
AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
private.