Bug 254289 - Branding
Summary: Branding
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Releng (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: RC   Edit
Assignee: Nick Boldt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 271497
Blocks: 252813
  Show dependency tree
 
Reported: 2008-11-05 19:41 EST by Anne Jacko CLA
Modified: 2018-01-22 11:36 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne Jacko CLA 2008-11-05 19:41:13 EST
+++ This bug was initially created as a clone of Bug #252813 +++

Each major project (the top-level projects except for the Tools and Technology projects where it is the sub-projects) should have an About dialog icon and contribute to the welcome page.
Comment 1 Eike Stepper CLA 2008-12-11 15:44:51 EST
Recognized for CDO/Net4j.
Comment 2 Martin Taal CLA 2008-12-11 16:02:56 EST
Recognized by Teneo
Comment 3 Christian Damus CLA 2009-01-27 13:22:41 EST
Query, Transaction, and Validation components all use the Modeling Project icon and now reference "Eclipse Modeling Project" as their provider name (no longer "Eclipse.org").
Comment 4 Dave Steinberg CLA 2009-04-07 15:17:41 EDT
Branding plug-ins must use the Modeling Project icon (modeling32.png) as the feature image and specify "Eclipse Modeling Project" as the bundle vendor (ideally, all plug-ins should do the latter). Features must also specify "Eclipse Modeling Project" as the provider name.

This is done for EMF core. We won't be contributing Welcome content this time around, though. Maybe that should be done at the top level of the Modeling Project at some point.
Comment 5 Dave Steinberg CLA 2009-05-06 09:40:23 EDT
Looking for confirmation from CDO and Teneo: is this done?
Comment 6 Eike Stepper CLA 2009-05-06 11:18:33 EDT
CDO/Net4j uses the branding icon.
Comment 7 Dave Steinberg CLA 2009-05-06 11:25:22 EDT
And "Eclipse Modeling Project" as the vendor?
Comment 8 Eike Stepper CLA 2009-05-06 12:30:02 EDT
(In reply to comment #7)
> And "Eclipse Modeling Project" as the vendor?

No ;-(

I did it now and it will be in the next build. So: Done ;-)

Comment 9 Martin Taal CLA 2009-05-06 13:44:56 EDT
Teneo plugins have the modeling32.png icon and has Eclipse Modeling Project as the plugin provider in all plugin.properties.

If that's enough (is it?) then Teneo is done for this one.

gr. Martin
Comment 10 Dave Steinberg CLA 2009-05-06 14:53:59 EDT
It sounds like you've got it. The key thing to check is that there aren't multiple copies of the same modeling icon on the About dialog. Or, if there are, that all your features are listed in the "Eclipse Modeling Project" one along with the core EMF features (indicating that it's some other project that hasn't satisfied this requirement yet).

Less important, but still worth doing, is to set the provider-name to "Eclipse Modeling Project" for all of your features as well (via the feature.xml or externalized into the feature.properties). That's determines what shows in the Properties dialog when you're browsing features to install.
Comment 11 Martin Taal CLA 2009-05-06 14:59:07 EDT
Hi Dave, thanks, yes I also updated the feature.properties (Eike pointed that out to me already). 
I will do a new build and then check how that installs in M7.

gr. Martin
Comment 12 Dave Steinberg CLA 2009-05-10 22:01:05 EDT
All done.
Comment 13 Ed Merks CLA 2018-01-22 11:36:54 EST
Closing all fixed releng bugs.