Bug 253926 - Add Equinox Declarative Services bundle to the Eclipse SDK
Summary: Add Equinox Declarative Services bundle to the Eclipse SDK
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 enhancement with 5 votes (vote)
Target Milestone: 3.5 M6   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 261061 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-05 10:05 EST by Kai Toedter CLA
Modified: 2009-02-11 10:01 EST (History)
14 users (show)

See Also:


Attachments
patch (985 bytes, patch)
2009-02-03 14:39 EST, Kim Moir CLA
no flags Details | Diff
patch (15.35 KB, patch)
2009-02-03 15:29 EST, Kim Moir CLA
no flags Details | Diff
patch (15.34 KB, text/plain)
2009-02-04 08:58 EST, Kim Moir CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Toedter CLA 2008-11-05 10:05:38 EST
Build ID: I20081030-1917

In Eclipse 3.5 M3, the new Service Component Editor (For OSGi Declarative Services XML files) is introduced. This is great, but to use DS, the Equinox DS bundle is needed. It would be great if the DS bundle would be shipped with the Eclipse SDK.
Comment 1 John Arthorne CLA 2009-01-26 12:01:04 EST
*** Bug 261061 has been marked as a duplicate of this bug. ***
Comment 2 Heiko Seeberger CLA 2009-01-26 23:54:30 EST
+1 for shipping
Comment 3 Gunnar Wagenknecht CLA 2009-01-27 02:59:41 EST
+1
Comment 4 Pavlin Dobrev CLA 2009-01-27 03:56:51 EST
+1
Comment 5 Markus Kuppe CLA 2009-01-27 03:58:22 EST
+1
Comment 6 Wolfgang Schell CLA 2009-01-27 04:41:56 EST
+1
Comment 7 Benjamin Cabé CLA 2009-01-27 15:27:43 EST
+1!
Comment 8 Chris Aniszczyk CLA 2009-02-03 13:34:29 EST
So let's do this for M6 guys.

I assume all that needs to be done is for Kim to update the map files and add DS to a feature. Which feature?
Comment 9 John Arthorne CLA 2009-02-03 13:40:49 EST
It has to go into org.eclipse.rcp, so that all bundles can use it. Most bundles that use services today are in org.eclipse.rcp.
Comment 10 Chris Aniszczyk CLA 2009-02-03 13:41:49 EST
Kim, do you want to update the map file and feature for:

org.eclipse.equinox.ds
org.eclipse.equinox.util

I think that's it and we should see it in the next i-build.
Comment 11 Kim Moir CLA 2009-02-03 13:45:19 EST
Chris, please update the map files with the versions of org.eclipse.equinox.ds
and org.eclipse.equinox.util that you'll be releasing.  I'll update the rcp feature and run a test build with this fix and other bugs.
Comment 12 Chris Aniszczyk CLA 2009-02-03 13:47:14 EST
Someone with commit rights to Equinox DS should do the map file and tagging.

Pavlin? Tom? John?
Comment 13 Thomas Watson CLA 2009-02-03 13:56:21 EST
(In reply to comment #11)
> Chris, please update the map files with the versions of org.eclipse.equinox.ds
> and org.eclipse.equinox.util that you'll be releasing.  I'll update the rcp
> feature and run a test build with this fix and other bugs.
> 

The core.map already has these two bundles tagged.  They are already built as part of the Equinox SDK.
Comment 14 Kim Moir CLA 2009-02-03 14:39:32 EST
Created attachment 124598 [details]
patch
Comment 15 Kim Moir CLA 2009-02-03 15:29:16 EST
Created attachment 124603 [details]
patch

John mentioned some other required changes.
Comment 16 Kim Moir CLA 2009-02-03 19:10:29 EST
Test build failed with this, 

/builds/N200902031636/org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk/customTargets.xml:13: The following error occurred while executing this line:
/builds/N200902031636/org.eclipse.releng.basebuilder/plugins/org.eclipse.pde.build_3.5.0.v20090129/scripts/genericTargets.xml:95: Bundle org.eclipse.equinox.ds_0.0.0 failed to resolve.:
	Unsatisfied import package org.eclipse.equinox.internal.util.event_1.0.0.
	Unsatisfied import package org.eclipse.equinox.internal.util.hash_1.0.0.
	Unsatisfied import package org.eclipse.equinox.internal.util.pool_1.0.0.
	Unsatisfied import package org.eclipse.equinox.internal.util.ref_1.0.0.
	Unsatisfied import package org.eclipse.equinox.internal.util.threadpool_1.0.0.
	Unsatisfied import package org.eclipse.equinox.internal.util.timer_1.0.0.

I'll investigate tomorrow.  Reverting patches.
Comment 17 Chris Aniszczyk CLA 2009-02-03 19:26:01 EST
The patch looks suspect...

+    <plugin
+         id="org.eclipse.equinox.ds"
+         download-size="0"
+         install-size="0"
+         version="0.0.0"
+         unpack="false"/>       
+        
+    <plugin
+         id="and org.eclipse.equinox.util"
+         download-size="0"
+         install-size="0"


That's a bad id? and unpack should be false...
Comment 18 Kim Moir CLA 2009-02-04 08:58:09 EST
Created attachment 124673 [details]
patch

id was bogus in previous patch
Comment 19 Chris Aniszczyk CLA 2009-02-05 09:00:15 EST
That looks like the problem.

The only other issue remaining is making sure equinox.util is set to lazy start.
Comment 21 John Arthorne CLA 2009-02-06 14:55:55 EST
Looks great Kim! I confirmed running this build that the two new bundles are there, and org.eclipse.equinox.ds is auto-started at start level 2.
Comment 22 Kim Moir CLA 2009-02-06 15:05:00 EST
Thanks John, I've tagged the features for the I-build.
Comment 23 John Arthorne CLA 2009-02-11 10:01:22 EST
Done.