Community
Participate
Working Groups
Created attachment 117061 [details] ParamenterHint-BadFunctionality Have the next php code in editor: <?php class bank{ } /** *This function deposits bank checks * *@param int $check_number *@param float $check_sum *@param bank $bank_info * */ function deposit_check($check_num,$check_sum,$bank_info){ } deposit_check(|) //<-Invoke Parameter hint ('ctrl+shift+space') here, where //the cursor "|" is located ?> Move the cursor using keyboard arrows buttons (<- or ->) Expected: The Parameter hint window should be closed. Actual: The Parameter hint window is still opened. See the attachment.
Created attachment 157705 [details] patch
<?php class bank{ } /** *This function deposits bank checks * *@param int $check_number *@param float $check_sum *@param bank $bank_info * */ function deposit_check($check_num,$check_sum,$bank_info){ } deposit_check(|) ; deposit_check() ?> Actually the Parameter hint window will be there when your cursor moves to the second deposit_check() call. In my opinion i think the patch is reasonable.What do you think of it?
Maybe the code in class PHPCompletionProposalComputer should be improve more,for there may be more than one "(" and ")",but basically i think it works when there are only one "(" and ")" pair.So i think i need think about this bug again to see if there is some better way:)
Created attachment 160394 [details] new patch Maybe this patch is better:)
Zhongwei, your patch is partially work. Could you double check the logic in the PHPContextInformationValidator.java to make sure that when the cursor move to up, down, left and right then the hint windows will be close. At the moment, move down to next line, and move to left will not make the window be closed.
Created attachment 161574 [details] patch
Applied the patch. Thanks
Tested in EclipsePdt-2.2.0.v20100427 Verified fixed. Kalin Yanev kalin.a@zend.com
