Bug 253830 - TextAttributeEditor does not draw borders for editable attributes on linux
Summary: TextAttributeEditor does not draw borders for editable attributes on linux
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-11-04 19:42 EST by Shawn Minto CLA
Modified: 2008-11-04 20:01 EST (History)
1 user (show)

See Also:

Attachments
patch (1.50 KB, patch)
2008-11-04 19:46 EST, Shawn Minto CLA 		no flags Details | Diff
mylyn/context/zip (916 bytes, application/octet-stream)
2008-11-04 19:47 EST, Shawn Minto CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2008-11-04 19:42:53 EST 
The data FormToolkit.KEY_DRAW_BORDER is only set to false if the attribute is read-only and is never set to true if it is editable.  On Linux, this results in fields that have no border so it is difficult to tell if the field is editable or not.
Comment 1 Shawn Minto CLA 2008-11-04 19:46:56 EST 
Created attachment 117025 [details]
patch

Here is a patch that adds the draw borders data and paints the borders for the composite that the text was created on.  Steffen, does painting the borders everytime an attribute editor is created affect the performance?
Comment 2 Shawn Minto CLA 2008-11-04 19:47:01 EST 
Created attachment 117026 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2008-11-04 19:57:14 EST 
Good catch. I have applied the change that sets border flag. 

Painting borders should be invoked by the class using the attribute editor. This is generally done in the editor parts, e.g. toolkit.paintBordersFor(attributesComposite) in TaskEditorAttributePart.expandSection() . Let me know if that doesn't work for you.
Comment 4 Shawn Minto CLA 2008-11-04 20:01:01 EST 
(In reply to comment #3)
> Good catch. I have applied the change that sets border flag.
Great!

> Painting borders should be invoked by the class using the attribute editor. This
> is generally done in the editor parts, e.g.
> toolkit.paintBordersFor(attributesComposite) in
> TaskEditorAttributePart.expandSection() . Let me know if that doesn't work for
> you.
Yup, this was my fault.  The paint borders isnt needed in this patch.