Bug 253661 - [regression] Code assist preferences page - "completion inserts" check box - bad functionality
Summary: [regression] Code assist preferences page - "completion inserts" check box - ...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Roy Ganor CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-11-04 04:39 EST by Kalin CLA
Modified: 2020-05-14 10:16 EDT (History)
4 users (show)

See Also:


Attachments
patch (5.06 KB, patch)
2010-02-22 19:34 EST, Zhongwei Zhao CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalin CLA 2008-11-04 04:39:20 EST
Go to Code Assist preferences page.

Check if the completion inserts a code

Tick "Completion Inserts" check box. 
Have the following PHP code:
<?
class national{
}
class natural{
}

$journal = new na|tional(); // | is a cursor sign location
?>
At the cursor sign location rise Code Assist window (Ctrl + Space).
From the list choose "natural"


Expected:
The "natural();" is inserted  before the  "tional()" class declaration segment:

$journal = new natural()tional();


Actual:
$journal = new natualtional();


Brackets are missing. 

Found in N20081103
Comment 1 Michael Spector CLA 2009-06-17 12:01:41 EDT
This was fixed a long time ago.
Comment 2 Gadi Goldbarg CLA 2009-06-25 07:20:34 EDT
Still reproducible in eclipse-php-galileo-RC4-win32
Kalin Yanev
kalin.a@zend.com
Comment 3 Zhongwei Zhao CLA 2010-02-22 19:34:38 EST
Created attachment 159872 [details]
patch
Comment 4 Q.S. Wang CLA 2010-03-09 04:16:21 EST
Applied the patch.
Thanks for contribution.
Comment 5 Gadi Goldbarg CLA 2010-05-05 04:03:11 EDT
Tested in EclipsePdt-2.2.0.v20100427
Still reproducible.
Reopening....
Kalin Yanev
kalin.a@zend.com
Comment 6 Zhongwei Zhao CLA 2010-05-05 04:30:23 EDT
fixed in latest code.
Comment 7 Gadi Goldbarg CLA 2010-05-17 09:23:21 EDT
EclipsePdt 2.2.0.v20100517
Verified fixed.

Kalin Yanev
kalin.a@zend.com