Comment 1 Hiroyuki 2008-11-01 07:14:07 EDT

Created attachment 116683 [details]
org.eclipse.mylyn.bugzilla.ide.patch

Comment 2 Hiroyuki 2008-11-01 07:47:27 EDT

Created attachment 116684 [details]
org.eclipse.mylyn.bugzilla-feature.patch

Comment 3 Hiroyuki 2008-11-01 07:47:58 EDT

Created attachment 116685 [details]
org.eclipse.mylyn.bugzilla.core.patch

Comment 4 Hiroyuki 2008-11-01 07:48:24 EDT

Created attachment 116686 [details]
org.eclipse.mylyn.bugzilla.ui.patch

Comment 5 Hiroyuki 2008-11-01 20:42:48 EDT

Created attachment 116712 [details]
org.eclipse.mylyn.bugzilla-feature.patch (again)

Comment 6 Hiroyuki 2008-11-01 20:43:16 EDT

Created attachment 116713 [details]
org.eclipse.mylyn.bugzilla.core.patch (again)

Comment 7 Hiroyuki 2008-11-01 20:43:44 EDT

Created attachment 116714 [details]
org.eclipse.mylyn.bugzilla.ide.patch (again)

Comment 8 Hiroyuki 2008-11-01 20:44:43 EDT

Created attachment 116715 [details]
org.eclipse.mylyn.bugzilla.ui.patch (again)

Comment 9 Steffen Pingel 2008-11-02 16:17:28 EST

I have applied the patches for bugzilla-feature and bugzilla.ide. I skipped externalization of some strings in the plugin.xml of bugzilla.ide since they are not dependent on the locale.

I am holding off with bugzilla.core and bugzilla.ui for now (see bug 215116 comment 17).

Comment 10 Steffen Pingel 2008-12-03 00:21:34 EST

Rob, I'll hand this over to you. Please consider these patches as soon as other outstanding contributions have been merged. Ping me once you are ready to merge and we can go over the string externalization process together.

Comment 11 Robert Elves 2008-12-15 19:39:27 EST

Patches applied, ip log updated.  Thanks Hiroyuki!

Comment 12 Hiroyuki 2008-12-16 07:42:07 EST

There is a problem also in the message text.

Example;
  English: This is BBB in AAA. 
  Japanese: xxxx AAA xxxx BBB xxx.

The position of AAA and BBB in the sentence is different according to the language. 
The message should be buried and be edited when internationalizing it. 
Do not make the message by the string concatenation when internationalizing it.

String word1 = ?BBB?;
String word2 = ?AAA?;
String message;

NG: message = ?This is ? + word1 + ? in ? + word2 + ?.?;
OK: Message = MessageFormat.format(?This is {0} in {1}.?, word1, word2);

Comment 13 Hiroyuki 2008-12-16 07:45:18 EST

Created attachment 120562 [details]
bugzilla.ui_fixmsg.patch

Patch for #12

Comment 14 Hiroyuki 2008-12-16 08:08:00 EST

In org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java
"Unable to parse response from "  is made externalize.
But, the same string of the another code is not made externalize.
I think that externalize is unnecessary because it  which is text for the exception. 

Comment 15 Robert Elves 2008-12-16 13:09:22 EST

(In reply to comment #13)
> Created an attachment (id=120562)
> bugzilla.ui_fixmsg.patch
> 
> Patch for #12
Patch applied, ip log updated.

(In reply to comment #14)
> In
> org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java
> "Unable to parse response from "  is made externalize.
> But, the same string of the another code is not made externalize.
> I think that externalize is unnecessary because it  which is text for the
> exception.
Fixed.

Comment 16 Steffen Pingel 2008-12-16 13:50:43 EST

Marking resolved. Please use bug 258358 to track any remaining nits.