Bug 252964 - [TabbedProperties] TabbedPropertyRegistry logs error when no contributors are available
Summary: [TabbedProperties] TabbedPropertyRegistry logs error when no contributors are...
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-31 09:07 EDT by Danail Branekov CLA
Modified: 2019-09-06 16:18 EDT (History)
0 users

See Also:


Attachments
Sample project (15.98 KB, application/zip)
2008-10-31 09:07 EDT, Danail Branekov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Danail Branekov CLA 2008-10-31 09:07:15 EDT
Created attachment 116611 [details]
Sample project

Build ID: M20080703-0800

Steps To Reproduce:
1. Import the test project attached (the project defines a sample view which should get tabbed properties contributed). For developiing this view I have followed http://www.eclipse.org/articles/Article-Tabbed-Properties/tabbed_properties_view.html
2. Start a runtime workbench
3. In the newly started open the properties view
4. Open the sample view
5. The following log entry appears
!ENTRY org.eclipse.ui.views.properties.tabbed 4 4 2008-10-31 14:57:37.196
!MESSAGE Contributor my.dummy.contributor cannot be created.



More information:
Hi,

The behaviour described above is due to the implementation of the org.eclipse.ui.internal.views.properties.tabbed.view.TabbedPropertyRegistry class.
Whenever such a registry is created with a given contributor id, the plugin registry is searched for contributions. When there are no such contributions, the factory treats the situation as an error. This is not nice because in a given set of installed plugins you may not have contributors to this id (e.g. the user may have disabled contributing plugins for some reason). Probably "INFO" severity would be more approriate here.


Best regards, Danail
Comment 1 Anthony Hunter CLA 2008-11-04 16:53:50 EST
By design this is an error.

You say you are providing a tabbed property sheet page so your workbench part must implement ITabbedPropertySheetPageContributor.

You then say that your contributor id is "my.dummy.contributor" but do not provide a propertyContributor extension for it.

In your view, simply define the propertyContributor extension without tabs and sections and you are done. Tabs and sections can go in other plug-ins.
Comment 2 Danail Branekov CLA 2008-11-05 02:13:58 EST
Hi Anthony,

From my design point of view it is pretty fine to have a view which implements the ITabbedPropertySheetPageContributor. If there will be contributors to it or not might be up to other tools.
For example, in my case, I am developing something like a framework (which contains a view) which expects other plugins to contribute stuff to it. Therefore this "framework" provides quite a lot of entry points (one of which is the tabbed property feature) for contributors to plug in. The framework itself does not care to provide properties at all - it simply needs to provide functionality to its contributors.
As there might be no contributors (the user missed to install them or has simply disabled them) you would get this error entry. Defining a dummy contributor would be simply a workaround and would simply hide the issue.

Regards, Danail
Comment 3 Anthony Hunter CLA 2008-11-05 09:50:47 EST
ok, we cannot remove the message to the log, so you are just requesting it be an INFO rather than ERROR?
Comment 4 Danail Branekov CLA 2008-11-05 09:54:19 EST
Yes, this is my request. The reason for it is that in our local infrastructure we have an automated test which opens all perspectives and views and verifies that there are error entries in the log file. If this test failed, quality management makes our lives miserable :)

Thanks for understanding!
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:18:09 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.