Bug 25165 - [Editor Mgmt] Allow option for not showing icons on editor tabs
Summary: [Editor Mgmt] Allow option for not showing icons on editor tabs
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0.2   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Michael Van Meekeren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 15826 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-10-22 06:00 EDT by Jon Skeet CLA
Modified: 2005-02-20 02:49 EST (History)
2 users (show)

See Also:


Attachments
Version of M5 EditorWorkbook which allows editors to not show icons (29.97 KB, text/plain)
2003-02-13 06:14 EST, Jon Skeet CLA
no flags Details
Version of M5 IPreferenceConstants which allows editors to not show icons (7.32 KB, text/plain)
2003-02-13 06:14 EST, Jon Skeet CLA
no flags Details
Version of M5 EditorsPreferencePage which allows editors to not show icons (23.68 KB, text/plain)
2003-02-13 06:15 EST, Jon Skeet CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Skeet CLA 2002-10-22 06:00:11 EDT
In certain perspectives, it makes sense to have a fairly small editor window.
Unfortunately, when you also want a fair number of tabs, you end up not seeing
much of the filename, as the icons take up so much of the space.

Could we have a preference for whether or not to include the icons in the editor
tabs? I can't say I often look at them, and they're *usually* all the same (as
people tend to edit files of the same type in one session).

Admittedly the benefit of this change would be reduced if other feature requests
such as allowing multiple rows of tabs or tabs down the side are implemented,
but it might still be worth doing (and I'd imagine it's easy to do...)
Comment 1 Kurt Kellner CLA 2002-11-15 11:48:28 EST
The following bugs are all related to the same issue:

Bug 20626
Bug 21968
Bug 22716
Bug 25165

Can the priority of this issue be increased?
Comment 2 Eduardo Pereira CLA 2002-11-18 10:52:09 EST
Even though we did not change the priority on this bug report, we are working 
on it. We don't have a solution for it yet.
Comment 3 Andrew Irvine CLA 2002-12-06 10:24:24 EST
Eclipse 20021203 introduced a new editor management strategy, a view was 
introduced (window>show view>other>basic>editors) as well as a menu pulldown on 
the far right side of the tab bar.  In addition you can specify the amount of 
compression your tabs take (window>preferences>workbench>editors).  With these 
new features do you still believe an option should be provided to remove the 
icon from the tabs?
Comment 4 Jon Skeet CLA 2002-12-09 03:48:54 EST
I haven't looked at the new features yet, but I don't think they'll remove the
"niceness" of the ability to remove icons. The fact still remains that the icons
do no good but *do* take up filename real-estate in many (but not all)
situations. Having the option to remove them seems to be a purely good thing
with no drawbacks other than the obvious one of development time. Possibly the
new features would make it worth pushing back to after 2.1, but I'd still like
to see it at some stage :)
Comment 5 Andrew Irvine CLA 2002-12-09 07:50:24 EST
The system menu would be lost if we did not display the icon, left click over 
the icon.  This menu is required for accessiblity.
Comment 6 Jon Skeet CLA 2002-12-09 08:00:38 EST
I wouldn't dream of suggesting it should be removed totally, or even by default
- just have an option. Then those who need the icon for accessibility reasons
can have it, and those who don't can see more of the filename :)
Comment 7 Kevin Haaland CLA 2003-02-07 16:54:16 EST
There are no plans for the UI team to work on this defect until higher priority 
items are addressed.  If you would like to work on a fix for this enhancement, 
please let us know on the platform-ui-dev mailing list.
Comment 8 Jon Skeet CLA 2003-02-13 06:12:17 EST
I've come up with a fix. I don't know how elegant it is, I'm afraid, being
pretty unfamiliar with the Eclipse sources. There's also at least one important
TODO in there: namely that the preference text isn't fetched from the resource
bundle at the moment, merely 'cos I couldn't find that resource bundle! The
appropriate line of code is present and waiting to be commented in (and the
current one commented out) if someone could also do the text in the resource bundle.

I'm obviously not expecting this to get into 2.1 at this stage, but if it were
to get into 2.2 in some form or other, I'd be very happy :)

In a minute I'll attach my versions of EditorPreferencePage,
IPreferenceStoreConstants and EditorWorkbook, so people can give this a go if
they'd like. There aren't many changes between these and M5, but I see things
have changed since M5, and I'd rather not try to guess as to what to do. If
you'd like me to work with a newer build and try to patch that and submit the
patches, let me know which build etc.
Comment 9 Jon Skeet CLA 2003-02-13 06:14:25 EST
Created attachment 3465 [details]
Version of M5 EditorWorkbook which allows editors to not show icons
Comment 10 Jon Skeet CLA 2003-02-13 06:14:54 EST
Created attachment 3466 [details]
Version of M5 IPreferenceConstants which allows editors to not show icons
Comment 11 Jon Skeet CLA 2003-02-13 06:15:23 EST
Created attachment 3467 [details]
Version of M5 EditorsPreferencePage which allows editors to not show icons
Comment 12 Jon Skeet CLA 2003-02-13 06:24:02 EST
Another "to-do" with my current implementation: the default would have to be
true, not false, in order to leave current behaviour - and I don't know how to
do that, I'm afraid :(
Comment 13 Andrew Irvine CLA 2003-04-10 13:07:47 EDT
*** Bug 15826 has been marked as a duplicate of this bug. ***
Comment 14 Michael Van Meekeren CLA 2004-02-16 16:04:36 EST
Currently there are two modes in the editor tab management, one for multiple 
and one for a single tabbed editor workbook this should answer the needs here.

Removing the icons removes important informational cues (such as errors) and 
not just the type of editor being used, however I believe the current support 
still supplies the needed features mentioned here, i.e. see more of the name 
of a file being edited even with a fair number of editors open

marking as fixed
Comment 15 Jon Skeet CLA 2005-02-20 02:49:45 EST
No, the current support *doesn't* fix the need. The icon still takes up room for
a purpose which I for one don't want it to. There are plenty of other ways I can
see which files have errors in, for instance. I don't want it taking up that
valuable real estate at the top of the page.

See bug 36008 for a patch which optionally removes the icon, leaving it on by
default.