Bug 251469 - Accessible.getDescription should not return name
Summary: Accessible.getDescription should not return name
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Scott Kovatch CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2008-10-20 15:52 EDT by Carolyn MacLeod CLA
Modified: 2008-10-29 14:44 EDT (History)
3 users (show)

See Also:


Attachments
patch to not return name in getDescription (1.53 KB, patch)
2008-10-20 16:00 EDT, Carolyn MacLeod CLA
no flags Details | Diff
new patch to not return name in getDescription (1.54 KB, patch)
2008-10-20 16:51 EDT, Carolyn MacLeod CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2008-10-20 15:52:59 EDT
- Load SWT Cocoa and the SWT examples from HEAD.
- Run org.eclipse.swt.examples.accessibility.AccessibleShapesExample
- turn on VoiceOver
- type the TAB key to give focus to the various shapes
Note that the shapes report their name twice.

In Accessible.getDescription(), if there isn't any description, then we should just return, instead of asking the application for a name.
Comment 1 Carolyn MacLeod CLA 2008-10-20 16:00:06 EDT
Created attachment 115613 [details]
patch to not return name in getDescription

Here's a patch.
Comment 2 Carolyn MacLeod CLA 2008-10-20 16:30:45 EDT
OK... the patch works properly from a VoiceOver point of view, but it generates exceptions because Cocoa thinks SWTView should implement getDescription. But there's a bigger problem here - why is everything being delegated to the super if the accessible doesn't implement it? We should be answering more "nulls", i.e. doing less work. In general, just delegate back to Cocoa instead of trying to see if some super will handle the request.
Comment 3 Carolyn MacLeod CLA 2008-10-20 16:51:29 EDT
Created attachment 115623 [details]
new patch to not return name in getDescription

Ignore the discussion in comment 2 - I will open a new bug for that. In the meantime, here is a patch that simply fixes this bug (name spoken twice), and doesn't try to delete more code at the same time <g>.
Comment 4 Scott Kovatch CLA 2008-10-22 15:34:59 EDT
Fixed >= 20081022.