Bug 251195 - [Markers] Quick fix is not available in Markers view
Summary: [Markers] Quick fix is not available in Markers view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Hitesh CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks: 238335
  Show dependency tree
 
Reported: 2008-10-17 05:44 EDT by Kaloyan Raev CLA
Modified: 2009-06-01 14:22 EDT (History)
14 users (show)

See Also:

Attachments
screenshot (15.27 KB, image/png)
2008-10-17 05:53 EDT, Kaloyan Raev CLA 		no flags Details
patch (1.36 KB, patch)
2008-10-20 15:50 EDT, Tod Creasey CLA 		no flags Details | Diff
patch handler and command (3.49 KB, patch)
2008-11-26 02:09 EST, Hitesh CLA 		emoffatt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2008-10-17 05:44:53 EDT 
In WTP we consider replacing the Problems and Tasks view with the Markers view. 

I have noticed a major limitation in the Markers view when working with 'problem' markers - The Quick Fix action is not available (see the attached screenshot): neither in the context menu, nor as a hotkey. 

I suspect that the root of the problem is that the Markers view has only actions that are common for all markers type and discards actions that are specific for each marker type.
Comment 1 Kaloyan Raev CLA 2008-10-17 05:53:42 EDT 
Created attachment 115376 [details]
screenshot
Comment 2 Remy Suen CLA 2008-10-17 07:11:35 EDT 
Reproduced on I20081007-1600.
Comment 3 Tod Creasey CLA 2008-10-20 15:50:01 EDT 
Created attachment 115609 [details]
patch

We use a trick where every command that is bound to MarkersView shows up in all MarkersViews - see init(IViewSite site, IMemento memento) in ExtendedMarkersView.

In the case of QucikFix is set to only enable when the problems view is showing - you need to add the markers view too. I'll attach a patch to the bug. Quick fix was a special case as we had to filter it out of tasks and bookmarks.
Comment 4 Kaloyan Raev CLA 2008-10-21 05:56:39 EDT 
I applied this patch on top of I20081007-1600. 
It really adds the 'Quick fix' action the the context menu, but:
  * it is always disabled no matter if there is a quick fix available. 
  * it appears for all marker types instead of only to Problems.
Comment 5 Kaloyan Raev CLA 2008-11-03 11:46:16 EST 
Ping... Do we have progress on this issue?
Comment 6 Hitesh CLA 2008-11-26 02:09:44 EST 
Created attachment 118743 [details]
patch handler and command

>   * it is always disabled no matter if there is a quick fix available. 
>   * it appears for all marker types instead of only to Problems. 

<with variable="selection">
     <iterate ifEmpty="false" operator="and">
            <adapt type="org.eclipse.core.resources.IMarker" >
                      <test value="org.eclipse.core.resources.problemmarker"
       				property="org.eclipse.ui.ide.marker.superType"/>
             </adapt>	
      </iterate>
</with>

This is not absolutely needed, but fixes 
>   * it appears for all marker types instead of only to Problems. 
Wondering if this would affect the time it takes for menu to show up.
Tod, your thoughts on the patch?
Comment 7 Kaloyan Raev CLA 2008-11-27 11:36:22 EST 
I have tried the patch and it seems to work properly.
Comment 8 Kaloyan Raev CLA 2009-01-14 08:20:21 EST 
Is there any chance that this patch goes in HEAD soon?
Comment 9 Hitesh CLA 2009-01-15 03:23:36 EST 
Eric, I think we should go ahead with the last patch.
Comment 10 Eric Moffatt CLA 2009-01-15 13:16:58 EST 
Committed in >20090115. Applied the patch.
Comment 11 Kaloyan Raev CLA 2009-01-19 05:30:46 EST 
Thank you!
Verified with N20090116-2000.