Bug 251074 - "Open Declaration" is duplicated in Navigate menu
Summary: "Open Declaration" is duplicated in Navigate menu
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Nir Cohen CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-10-16 08:01 EDT by Kalin CLA
Modified: 2020-05-14 11:16 EDT (History)
5 users (show)

See Also:
ganoro: iplog+

Attachments
TheOptionOpenDeclarationIsDuplicatedInMenu (116.31 KB, image/pjpeg)
2008-10-16 08:01 EDT, Kalin CLA 		no flags Details
The path to fix the issue in my comments (5.21 KB, patch)
2009-01-06 05:53 EST, Q.S. Wang CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalin CLA 2008-10-16 08:01:57 EDT 
Created attachment 115245 [details]
TheOptionOpenDeclarationIsDuplicatedInMenu

Go to Main menu -> Navigate

The option "Open Declaration" is duplicated in Navigate menu.

Tested in N20081015
Comment 1 Roy Ganor CLA 2008-10-16 13:24:02 EDT 
any chance to remove it from the view (see who contributes the second one)
Comment 2 Roy Ganor CLA 2008-11-02 07:44:23 EST 
targeting to PDT 2.0 M2
Comment 3 Nir Cohen CLA 2009-01-06 04:42:51 EST 
fixed
Comment 4 Q.S. Wang CLA 2009-01-06 05:51:36 EST 
Another issues there.
Since ActionContributorForPhp extends from WTP's ActionContributorHTML
class, there's action conflict between the child and parent class. In
ActionContributorXML class, which is the parent class of ActionContributorHTML,
it contributes a fOpenFileAction with the same name as "Open Declaration"
action. The work around is remove this menuitem in the ActionContributorForPhp.
Maybe we'll consider write a new ActionContributor which will not extends from
WTP one.
Comment 5 Q.S. Wang CLA 2009-01-06 05:53:00 EST 
Created attachment 121604 [details]
The path to fix the issue in my comments

The patch is against the head of CVS.
Comment 6 Roy Ganor CLA 2009-01-07 02:21:41 EST 
does the short key is missing (for F3)?
Qiangsheng fix should help with it,
Comment 7 Michael Spector CLA 2009-01-07 09:06:51 EST 
Applied to 2.0.1 and to HEAD.
Comment 8 Gadi Goldbarg CLA 2009-01-30 09:46:36 EST 
Verified Fixed.
pdt-all-in-one
2.1.0M4
I200901300153 

Kalin Yanev
kalin.a@zend.com