Community
Participate
Working Groups
When editor is closed - we can't open the dialog with CTRL+Shift+ H Expected: When a class and below is selected , ctrl+shift+h should open the dialog + populate the search field with selected element
targeting to PDT 2.0 M2
The same behavior when editor is opened, the focus is on PHP Explorer. When the focus is on the relevant element in PHP Editor - correct behavior ('Open Type in hierarchy' dialog is launched using shortcut CTRL+Shift+H) Tested on pdt-debugger-all-in-one-2.0.0RC1-linux-glibc23-i386
Created attachment 121906 [details] Define the shortcut key in plugin.xml file of DLTK
For fixing this bug, please apply the patch of bug 250554 at first, then apply the patch here.
Applied to DLTK.
Still reproducible. pdt-all-in-one 2.1.0M4 I200901300153 Build Dependencies: DLTK R1.0 1.0M4 200812290249 Kalin Yanev kalin.a@zend.com
Created attachment 157496 [details] patch This one is same as bug 250554. Shift+Ctrl+H should be Alt+Ctrl+H
Applied the patch.Thanks for contribution.
Reopen it. It should not use the DLTK action directly.
The issues here are: 1. DLTK contributes a set of open* actions(retarget actions), however it only contribute the key binding to the editor scope. 2. PHP explorer extends from DLTK script explorer, which gets those open* action on PHP explorer. However since the PHPExplorer needs define it's own context, and DLTK doesn't provides its own windows context, the key binding will not be activated then. That's why this bug was resolved but re-opened later. Solution: change the definition of PHP open* actions to non-retarget. Specify the class to a PHP local action, which can be a delegator to the DLTK actions. Define local key bindings. This should resolve the issue of PHPExplorer. 3. There's issues of contributing the open* actions to navigate group when the editor gets the focus. Solution: define the action set association between the open* action set and the PHP editor. Define local key bindings and etc. Reuse the action delegators which has been defined in step 2 above. Using this solution, all the actions are manged and contributed by PHP consistently. These solutions are for 250554 and 253193 as well. Zhongwei, would you want to make a try? Let me know if you have further questions.
fixed in head,close
Hi Zhongwei, I think your suggestion is wrong. The associated shortcuts should be as follows: Open Call Hierarchy = Ctrl+Alt++H Open Type Hierarchy = F4 Open Type in Hierarchy = Ctrl+Shift+H Look at Key Assist Table by Ctrl+Shift+L for more info. The subject of the issue is related to 'Open Type in Hierarchy' shortcut functionality. The problem is still reproducible. Shift+Ctrl+H takes no effect when the focus in on a class in PHP Explorer view. Tested in EclipsePdt-2.2.0.v20100427 Kalin Yanev kalin.a@zend.com
now Shift+Ctrl+H works,but not works as expected,there is another bug report the wrong behavior of Shift+Ctrl+H for PHP Explorer view(but I forget the number,and I talked with Kalin about that bug) which need to commit the patch to dltk,I have told Roy about that.
The above bug I said is Bug 258803,so I mark this bug fixed,because Shift+Ctrl+H works now
I close it as a Duplicate of Bug 258803 Zhao, thanks for contribution. Kalin Yanev kalin.a@zend.com *** This bug has been marked as a duplicate of bug 258803 ***
