Bug 250377 - Buckminster/Subversive inserts null into svn file urls
Summary: Buckminster/Subversive inserts null into svn file urls
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-10-10 03:36 EDT by Douglas Palmer CLA
Modified: 2019-02-25 14:39 EST (History)
1 user (show)

See Also:

Attachments
This patch should fix the issue (3.03 KB, patch)
2008-10-20 09:02 EDT, Douglas Palmer CLA 		no flags Details | Diff
Another patch; this one really works. (4.02 KB, patch)
2008-10-21 16:45 EDT, Douglas Palmer CLA 		thomas: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Palmer CLA 2008-10-10 03:36:05 EDT 
Build ID: 3.4

Steps To Reproduce:
1. Create an rmap that has an svn reader with a file url of the form file:///path/to/a/repository/trunk/{1} or file:/path/to/a/repository/trunk/{1}
2. Resolve a cquery against the rmap.
3. Buckminster will try to list the contents of file://null/svn/repos/spectra2/trunk/my.component#HEAD and will fail to resolve the cquery.


More information:
Comment 1 Douglas Palmer CLA 2008-10-20 09:02:39 EDT 
Created attachment 115553 [details]
This patch should fix the issue

I added a null check to getHosts() to prevent null being added to URLs.  However, the some additional changes were needed to get the correct number of '/' characters and to prevent IPaths from adding devices into the url.
Comment 2 Douglas Palmer CLA 2008-10-21 10:09:06 EDT 
Sorry, this patch isn't perfect, some cases still fail, I will try to fix it and create another patch.
Comment 3 Douglas Palmer CLA 2008-10-21 16:45:24 EDT 
Created attachment 115750 [details]
Another patch; this one really works.

Further protection for null host values were needed.
Comment 4 Thomas Hallgren CLA 2008-10-28 04:04:10 EDT 
Patch applied, thanks.
I also made the same changes to the Subclipse version of this class (the SVNSession).
Comment 5 Thomas Hallgren CLA 2008-10-28 09:31:17 EDT 
The fix is in revision 9591, now pushed to our update sites.