Bug 250164 - [artifactrepo] ProcessingStepHandler does not read processing steps properly
Summary: [artifactrepo] ProcessingStepHandler does not read processing steps properly
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Andrew Cattle CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 249372 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-08 15:42 EDT by Andrew Cattle CLA
Modified: 2008-11-05 16:14 EST (History)
1 user (show)

See Also:

Attachments
Changes how arguements are added to processing steps (1.48 KB, patch)
2008-10-08 15:42 EDT, Andrew Cattle CLA 		dj.houghton: iplog+
Details | Diff
Test to verify processing steps are carried out correclty (2.87 KB, text/plain)
2008-10-10 16:27 EDT, Andrew Cattle CLA 		dj.houghton: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cattle CLA 2008-10-08 15:42:20 EDT 
Created attachment 114592 [details]
Changes how arguements are added to processing steps

We ran into a problem where we noted that processing steps read into memory did not match those in the artifact.xml file
Comment 1 Andrew Cattle CLA 2008-10-08 15:45:03 EDT 
Forgot to mention: we briefly verified that the writer behaved correctly.
Comment 2 Pascal Rapicault CLA 2008-10-08 16:03:21 EDT 
I have released the patch. Could you please add two regression tests:
- one that from a repository get the packed artifact and verify that its is the same one than the canonical version of it 
- one that read a repository and confirm that the required attribute and the data attribute in the processingstepdescriptor are correct.
Comment 3 Andrew Cattle CLA 2008-10-10 16:27:07 EDT 
Created attachment 114834 [details]
Test to verify processing steps are carried out correclty

Note: I have other outgoing changes pending in the file so I could not create a patch. Place this code at the bottom of ArtifactMirrorApplicationTest.java.

This executes a packed artifact's processing steps and then verifies the file size against the canonical equivalent artifact in the source.

Also note that in my updated patch for bug 249996 I included a temporary isEqual(IArtifactDescriptor, IArtifactDescriptor) method in AbstractProvisionTest which is called whenever assertContains is called. This should verify the data and required attributes of the processing step descriptors.
Comment 4 Pascal Rapicault CLA 2008-10-15 15:08:34 EDT 
Andrew could you please create an updated patch of the change in the IO class. Thx
Comment 5 Pascal Rapicault CLA 2008-10-15 15:34:14 EDT 
test case released.
Comment 6 Pascal Rapicault CLA 2008-11-05 16:03:03 EST 
*** Bug 249372 has been marked as a duplicate of this bug. ***