Bug 249954 - [Patch] "Create Patch" creates invalid file if a new file ends with no newline
Summary: [Patch] "Create Patch" creates invalid file if a new file ends with no newline
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-07 09:51 EDT by Jerome Lanneluc CLA
Modified: 2009-06-02 06:57 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (777 bytes, patch)
2008-10-10 05:33 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-10-07 09:51:01 EDT 
I20080930-0921

1. Check out v_916 of:
  org.eclipse.jdt.core
  org.eclipse.jdt.core.tests.compiler
  org.eclipse.jdt.core.tests.model
2. Apply the non obsolete patch from bug 198572
3. Edit /org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/ManifestAnalyzer.java and remove the last cariage return
4. In the Synchronize view, select the 3 project and create a patch
5. Replace the3 projects with v_916
6. Attempt to apply the patch 
Observe: It tries to apply the modification in org.eclipse.jdt.core.tests.model to org.eclipse.jdt.core
Comment 1 Pawel Pogorzelski CLA 2008-10-10 05:33:21 EDT 
Created attachment 114769 [details]
Patch_v01

The problem shows up when the patch being generated contains a new file (not existing in CVS) with no line delimiter in the last line.

This bug was introduced with the fix for bug 116023.
Comment 2 Tomasz Zarna CLA 2008-10-10 05:54:38 EDT 
Released to HEAD. Thanks Pawel!