Bug 2498 - TextCellEditor.isSelectAllEnabled() is expensive (1GFBITI)
Summary: TextCellEditor.isSelectAllEnabled() is expensive (1GFBITI)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Haaland CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2001-10-10 22:37 EDT by Nick Edgar CLA
Modified: 2002-01-26 21:24 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2001-10-10 22:37:32 EDT 
TextCellEditor.isSelectAllEnabled() does text.getText().length.
This is expensive.
It's common to have Select All enabled even when the widget is empty.
Compare with Notepad and Windows Explorer.

Should change it to just return true.

NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 18:32:02 EST 
PRODUCT VERSION:
123
Comment 2 Nick Edgar CLA 2002-01-26 21:24:32 EST 
Changed to use getCharCount() > 0.