Bug 249574 - [Contributions] ExternalActionManager.addPropertyChangeListener() doesn't register the ListenerList
Summary: [Contributions] ExternalActionManager.addPropertyChangeListener() doesn't reg...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 290079 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-03 04:48 EDT by Prakash Rangaraj CLA
Modified: 2009-09-21 20:24 EDT (History)
2 users (show)

See Also:

Attachments
Fix for the bug (822 bytes, patch)
2008-10-03 04:48 EDT, Prakash Rangaraj CLA 		pwebster: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Prakash Rangaraj CLA 2008-10-03 04:48:37 EDT 
Created attachment 114163 [details]
Fix for the bug

Build ID:  I20080923-0800 

Steps To Reproduce:
Its currently:
} else if (existing != null) {
	ListenerList listeners = new ListenerList(ListenerList.IDENTITY);
	listeners.add(existing);
	listeners.add(listener);
} else {

Ideally it should be:

} else if (existing != null) {
	ListenerList listeners = new ListenerList(ListenerList.IDENTITY);
	listeners.add(existing);
	listeners.add(listener);
	registeredListeners.put(commandId, listeners);
} else {


More information:
Comment 1 Paul Webster CLA 2008-10-03 11:23:10 EDT 
(In reply to comment #0)
> Created an attachment (id=114163) [details]
> Fix for the bug

Released to HEAD >20081003
PW
Comment 2 Paul Webster CLA 2008-10-21 10:34:21 EDT 
re-assign
Comment 3 Paul Webster CLA 2008-10-21 10:34:44 EDT 
done
Comment 4 Remy Suen CLA 2009-09-21 20:24:25 EDT 
*** Bug 290079 has been marked as a duplicate of this bug. ***