Community
Participate
Working Groups
Build ID: M20080911-1700 Steps To Reproduce: I'm using the default commit template: ${connector.task.prefix} ${task.key}: ${task.description} ${task.url} and I'm working with the local repository. After updating Mylyn from 3.0.1 to 3.0.2 (and because of the fix for bug #242310), the commit message generated for my task changed from: task 47: My task name to: taskMy task name The problem is this: given that ${task.key} is not evaluated to task id anymore, why is " : " in the template cut? I would expected to see a space after "task", and a colon followed by a space before "My task name", so: task : My task name More information: I'm marking this bug as "major" because I think it's severity is increased by the fact that I think the change caused by the fix #242310 is by itself a breaking change and in this situation the comment generated for local tasks using the default template is ugly.
I'll consider this as part of the 3.1 plan.
*** Bug 250378 has been marked as a duplicate of this bug. ***
Any plans to fix this soon? one of consequences is that at SVN the default commit message is missing a space between the word "task - Complete" and the task title. For example: "task - Completedevelop a new feature xyz" this is a little annoying, to add the white-space every time I commit changes. See also subclipse bug report 950 (closed as duplicate of this bug): http://subclipse.tigris.org/issues/show_bug.cgi?id=950
The bug is on the back log and will be considered when the next release is planned.
This is now fixed. Trailing characters of a template variable were previously thrown away if the variable was not matched. Now, we make sure to add these trailing characters so that spaces and punctuation are properly handled between variables that do not match anything on the task. Steffen, do you think that this should be backported to the 3.3.x branch too?
Created attachment 159339 [details] mylyn/context/zip
Sure. Just post a patch and test case.
Created attachment 159391 [details] patch Here is the patch steffen.
Created attachment 159393 [details] patch Updated patch that was committed to the branch
patch applied to the branch and head.
Thanks Shawn.
