Bug 248926 - [Contributions] ShowInContext may also carry the source IWorkbenchPart
Summary: [Contributions] ShowInContext may also carry the source IWorkbenchPart
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 248103
  Show dependency tree
 
Reported: 2008-09-29 07:16 EDT by Markus Kuppe CLA
Modified: 2019-09-06 16:18 EDT (History)
1 user (show)

See Also:

Attachments
Also carry IWorkbenchPart part reference (2.83 KB, patch)
2008-09-29 07:20 EDT, Markus Kuppe CLA 		no flags Details | Diff
Added since tags (thanks Remy) (2.89 KB, patch)
2008-09-29 07:27 EDT, Markus Kuppe CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-09-29 07:16:18 EDT 
ShowInContext currently only carries the source selection as well as the source input. But this isn't enough for e.g. Bug #248103 that needs to know the source part (IWorkbenchPart) as well.
Comment 1 Markus Kuppe CLA 2008-09-29 07:20:41 EDT 
Created attachment 113723 [details]
Also carry IWorkbenchPart part reference
Comment 2 Markus Kuppe CLA 2008-09-29 07:27:00 EDT 
Created attachment 113725 [details]
Added since tags (thanks Remy)
Comment 3 Paul Webster CLA 2008-09-30 13:32:56 EDT 
What about simply providing something like:
      <menuContribution
            locationURI="popup:org.eclipse.ui.menus.showInMenu">
         <command
               commandId="org.eclipse.ui.views.showView"
               icon="platform:/plugin/org.eclipse.ui.views/icons/full/eview16/prop_ps.gif"
               label="Properties"
               style="push">
            <parameter
                  name="org.eclipse.ui.views.showView.viewId"
                  value="org.eclipse.ui.views.PropertySheet">
            </parameter>
         </command>
      </menuContribution>

PW
Comment 4 Markus Kuppe CLA 2008-10-02 08:51:32 EDT 
Thanks Paul, this satisfies my current requirement. IMO this can be set to WONTFIX.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:18:30 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.