Community
Participate
Working Groups
This is a split-off of bug #237857 where Matthew Hall has already provided an initial patch for tracking the staleness of the validation status observable. Updated patch which fixes some minor issues along with some unit tests follows.
Created attachment 113686 [details] The patch adapted from Matthew's patch along with some unit tests and JavaDoc updates. I've included both Matthew and myself in the contributors section of the ValidatedObservable(Value|List|Set|Map) files for this bug since I had to adapt some details. I hope that's the right thing to do. If not, please feel free to change that.
Created attachment 113689 [details] same patch but including the new ValidatedObservableMapTest file in the BindingTestSuite Sorry, I had forgotten to include it.
Ovidio, can you give an estimate of how many LOC from the patch are yours? The patch has 772 new/changed lines (well over the 250 threshold) however I know that a lot (most?) was copied from my work on 237857. If we can determine that your portion of the contribution is under that threshold then I think we can commit the patch without further review.
Matthew, indeed the only thing I did was introducing an additional flag (dirty) to differentiate between the more general staleness state (stale) and the more specific fact of being out of sync with the target observable (dirty). So the changes with respect to your original patch were quite limited. It's not easy to compare the two patches since there are many punctual changes but being conservative, I'd say that my changes do not go beyond 120 LOC, including the JavaDoc adaptations. In any case, I'd say the implementation is well below the 250 LOC but if you also count the unit tests, then it's clearly beyond the threshold. BTW, sorry for the inconvenience of having mixed up my contributions with your initial patch. I could have guessed that this would be no good when it comes to counting lines of code...
I will try to sort out which LOC belong to whom, and file an IPZilla for your patch. Later tonight I'll post some questions for information that the IP team needs. This would be a lot easier if you became a committer.. :)
Maybe when bug 237857 is fixed there will be less to fix and the effective portion of this patch will go below the LOC threshold--we'll see.
Moving to M5
Retargeting to 3.5M6
Out of time for 3.5--I should have submitted this for IP review but it fell through the cracks. Sorry.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
