Bug 248562 - [ActionSets] All ActionSets should be included in a capability somewhere
Summary: [ActionSets] All ActionSets should be included in a capability somewhere
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 260425 260426
Blocks: 254130
  Show dependency tree
 
Reported: 2008-09-25 09:18 EDT by Paul Webster CLA
Modified: 2009-03-11 02:57 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2008-09-25 09:18:04 EDT
All actionSets included by the eclipse SDK should be captured in a capability somewhere.  Some examples that were brought to our attention (not all Eclipse):

"External Tools"-"org.eclipse.ui.externaltools.ExternalToolsSet"
"Annotation
Navigation"-"org.eclipse.ui.edit.text.actionSet.annotationNavigation"
"Convert Line
Delimiters"-"org.eclipse.ui.edit.text.actionSet.convertLineDelimitersTo"
"SampleGalleryActionSetLabel"- "com.ibm.samplegallery.sampleGalleryActionSet"
"Software Updates"-"org.eclipse.update.ui.softwareUpdates"
"TutorialGalleryActionSetLabel"-
"com.ibm.01.tutorialgallery.tutorialGalleryActionSet"
"WebResources"-"com.ibm.rational.welcome.core.webResourcesActionSet"
"Open Files"-"org.eclipse.ui.edit.text.actionSet.openExternalFile"
"Working Sets"-"org.eclipse.ui.WorkingSetActionSet"

We need to include ours and open bugs against specific components to have theirs added.

PW
Comment 1 Kevin McGuire CLA 2008-10-02 10:14:32 EDT
agree good idea
Comment 2 Prakash Rangaraj CLA 2008-10-02 23:12:14 EDT
+1
Comment 3 Paul Webster CLA 2008-11-24 14:04:44 EST
Prakash as a starter for this we need to know:

1) what actionSets are defined in the SDK, plugin/id

2) what actionSets are already included in the activityPatternBindings we ship with the SDK

Then we would need to decide how best to capture the rest of the actionSets in either the existing activity pattern bindings or in new ones.

PW
Comment 4 Prakash Rangaraj CLA 2008-12-02 07:53:27 EST
These are the actionSets I've found in SDK

Bound to activities:
org.eclipse.jdt.debug.ui.JDTDebugActionSet - Java Debug
org.eclipse.jdt.junit.JUnitActionSet - JUnit
org.eclipse.jdt.ui.text.java.actionSet.presentation - Java Editor Presentation
org.eclipse.jdt.ui.JavaElementCreationActionSet - Java Element Creation
org.eclipse.jdt.ui.JavaActionSet - Java Navigation
org.eclipse.jdt.ui.A_OpenActionSet - Java Open Actions
org.eclipse.jdt.ui.SearchActionSet - Java Search
org.eclipse.jdt.ui.CodingActionSet - Java Coding
org.eclipse.pde.ui.SearchActionSet - Plug-in Search
org.eclipse.team.ui.actionSet - Team
org.eclipse.team.cvs.ui.CVSActionSet - CVS

Not bound:
org.eclipse.ant.ui.actionSet.presentation - Ant Editor Presentation
org.eclipse.debug.ui.breakpointActionSet - Breakpoints
org.eclipse.debug.ui.debugActionSet - Debug
org.eclipse.debug.ui.launchActionSet - Launch
org.eclipse.debug.ui.profileActionSet - Profile
org.eclipse.search.searchActionSet - Search
org.eclipse.ui.actionSet.openFiles - Open Files
org.eclipse.ui.actionSet.keyBindings - Keyboard Shortcuts
org.eclipse.ui.cheatsheets.actionSet - Cheat Sheets
org.eclipse.ui.edit.text.actionSet.annotationNavigation - Annotation Navigation
org.eclipse.ui.edit.text.actionSet.convertLineDelimitersTo - Convert Line Delimiters
org.eclipse.ui.edit.text.actionSet.presentation - Editor Presentation
org.eclipse.ui.edit.text.actionSet.navigation - Editor Navigation
org.eclipse.ui.externaltools.ExternalToolsSet - External Tools
org.eclipse.ui.WorkingSetModificationActionSet - Working Set Manipulation
org.eclipse.ui.WorkingSetActionSet - Window Working Set
org.eclipse.ui.NavigateActionSet - Resource Navigation

ant & debug actionsets can be bound to activity "Development"; edit actionSets can be under "Text Editing"; rest of them under generic activity like "IDE" ?
Comment 5 Boris Bokowski CLA 2009-01-08 10:46:52 EST
I talked to Kevin about this and we think the listed action sets fall into three categories: Debug, Ant, and IDE.

Our feeling is that we should do the following:

1. Create new sub-activities of "Development" for Ant and Debug. This will make it possible to get rid of the Ant- and Debug-related action sets (and other UI contributions of Ant and Debug such as views, preference pages etc).

2. Not create an activity for the remaining IDE action sets (and other "general IDE" UI contributions). The reason being that we don't think it makes sense to disable these if you are in an Eclipse-based IDE.

I am going to create two new bugs for this. We don't think there is any work left to do for Platform UI, but I will leave this bug open until the two new bugs are resolved.
Comment 6 Boris Bokowski CLA 2009-02-06 11:46:14 EST
(In reply to comment #5)
> I am going to create two new bugs for this. We don't think there is any work
> left to do for Platform UI, but I will leave this bug open until the two new
> bugs are resolved.

Marking as fixed because those two bugs are now fixed.
Comment 7 Prakash Rangaraj CLA 2009-03-11 02:57:52 EDT
Verified in I20090310-0100