Bug 248388 - Please fix a dispose method of GridColumn.
Summary: Please fix a dispose method of GridColumn.
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Nebula (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Mirko Paturzo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 03:00 EDT by Soichiro Yoshimura CLA
Modified: 2021-07-05 11:38 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Soichiro Yoshimura CLA 2008-09-24 03:00:30 EDT
Build ID: I20080617-2000

Steps To Reproduce:
GridColumnhave a number of not garbage collected fields caused by crossreferences.

Please fix dispose method of GridColumn.

GridColumn Line:224
::::FROM:::::::

 /**
     * {@inheritDoc}
     */
    public void dispose()
    {
        if (!parent.isDisposing())
        {
            parent.removeColumn(this);
            if (group != null)
                group.removeColumn(this);
        }
        super.dispose();
    }

::::TO:::::::
   /**
     * {@inheritDoc}
     */
    public void dispose()
    {
        if (!parent.isDisposing())
        {
            parent.removeColumn(this);
            parent = null;
            
            if (group != null)
            {
                group.removeColumn(this);
                group = null;
            }
        }
        
        if(cellRenderer != null)
        {
        	cellRenderer.setDisplay(null);
        	cellRenderer = null;
        }
        
        if(headerRenderer != null)
        {
        	headerRenderer.setDisplay(null);
        	headerRenderer = null;
        }
        
        super.dispose();
    }


More information:
Comment 1 Thomas Schindl CLA 2009-03-04 10:46:22 EST
Please create a patch against the header_footer branch then I'll commit it to CVS
Comment 2 Thomas Schindl CLA 2009-04-24 09:57:57 EDT
Could you please provide a patch against HEAD
Comment 3 Mirko Paturzo CLA 2014-03-26 06:51:47 EDT
Hi all,
i can working on it.. I would not want this commit is attributed to me..
Patch was created by Soichiro Yoshimura
Comment 4 Wim Jongman CLA 2014-04-24 11:51:46 EDT
(In reply to Mirko Paturzo from comment #3)
> Hi all,
> i can working on it.. I would not want this commit is attributed to me..
> Patch was created by Soichiro Yoshimura

Mirko, go ahead and implement this in this fashion. The number of lines are too small to cause us any problems.
Comment 5 Mirko Paturzo CLA 2014-04-29 02:53:04 EDT
Dispose method fixed