Bug 248265 - [results] M20080911-1700 results have no failure in scenario status table
Summary: [results] M20080911-1700 results have no failure in scenario status table
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2008-09-23 09:42 EDT by Frederic Fusier CLA
Modified: 2008-09-24 09:57 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (14.96 KB, patch)
2008-09-24 09:57 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-09-23 09:42:08 EDT 
While testing fix for bug 247936, I realized that icons in Scenario Status Table were wrong: all regressions over 10% still have an 'OK' icon instead of 'KO' expected one!

Accessing the perf releng DB directly, it appears that the 'FAILURE' table has no entry for the M20080911-1700 build :-( I do not know what happened while storing the failure in the database, however, it does not seem any longer necessary to store the failure while running performance tests has we can determine if the test fails or not while generating the HTML pages...

Setting the failure during the generation also have the advantage to minimize the DB accesses, reduce the local data files size and avoid to re-run the whole tests when such a problem occurred!
Comment 1 Frederic Fusier CLA 2008-09-24 09:57:16 EDT 
Created attachment 113360 [details]
Proposed patch

This patch computes the failure while initializing configuration results of the scenario. Then it's no longer necessary to request the database to get this piece of information.

Note that I haven't yet cleaned up the framework to get completely rid of the failure table. I'll provide a patch to do it soon...
Comment 2 Frederic Fusier CLA 2008-09-24 09:57:40 EDT 
Released for 3.5M3 in HEAD stream.