Bug 248251 - [results] Names of generated perf results data files may be too long
Summary: [results] Names of generated perf results data files may be too long
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2008-09-23 07:06 EDT by Frederic Fusier CLA
Modified: 2008-09-24 06:34 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (20.37 KB, patch)
2008-09-24 06:34 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-09-23 07:06:42 EDT 
Some scenarios have a very, very, very long name.
E.g. org.eclipse.ui.tests.performance.presentations.PresentationActivePartPropertyTest.Presentation org.eclipse.ui.internal.presentations.classic.WorkbenchPresentationFactoryClassic view active part properties()

As the scenario name is used for the name of the generated data files, this leads to OS error while managing these files (typically Windows Vista which gets lot of troubles while deleting these kind of files...).

It seems that the common allowed maximum for files name length is 256 characters. So, all generated files should have name length less than this...
Comment 1 Frederic Fusier CLA 2008-09-24 05:41:10 EDT 
Increase severity as it's really annoying.
Comment 2 Frederic Fusier CLA 2008-09-24 06:34:13 EDT 
Created attachment 113345 [details]
Proposed patch

The applied solution was to use "Scenario"+id for the scenario file name instead of one based on the name itself.

Note that the initial solution was to verify that the file name never exceeds 250 characters in the ScenarioData.createFile(...) method . However, this was an invalid solution because the file name was used in other classes (Main, ScenarioStatusTable and Fingerprint) while including an href to the generated file. Hence, changing its name would have broken this reference...
Comment 3 Frederic Fusier CLA 2008-09-24 06:34:36 EDT 
Released for 3.5M3 in HEAD stream.